Repository navigation
Codespaces: Use -R for --repo shorthand and deprecate -r - #6725
Merged
Merged
Conversation
cliAutomation
added
the
external
cmbrose
commented
Dec 12, 2022
|
|
||
| // addDeprecatedRepoShorthand adds a -r parameter (deprecated shorthand for --repo) | ||
| // which instructs the user to use -R instead. | ||
| func addDeprecatedRepoShorthand(cmd *cobra.Command, target *string) error { |
Member
Author
There was a problem hiding this comment.
If there are any suggestions for how to make this cleaner, I would love to improve this 😄 I couldn't figure out a way to mark -r as deprecated and still have -R added
jungaretti
approved these changes
Dec 13, 2022
|
|
||
| // addDeprecatedRepoShorthand adds a -r parameter (deprecated shorthand for --repo) | ||
| // which instructs the user to use -R instead. | ||
| func addDeprecatedRepoShorthand(cmd *cobra.Command, target *string) error { |
vilmibm
approved these changes
Dec 13, 2022
vilmibm
left a comment
vilmibm
left a comment
Contributor
There was a problem hiding this comment.
Looks like a fair approach given what tools Cobra provides. Thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #6548
The
codespacescommands use-ras shorthand for--repowhich is inconsistent with other commands which use-Rinstead. This change updates existing usage of-rto be-Rand marks usage of-ras hidden and deprecated.Examples:
-Rexists and-ris hidden:-Rworks like--repo:-rstill works, but warns about deprecation:Note that part of the motivation to make this change is to make #6548 more friendly - it removes a collision of
-ringh cs cpfor that change.