Repository navigation
pass apiClient to determineBaseRepo - #943
Merged
Merged
Conversation
Our code had an unspoken assumption that only one apiClient is created during the course of a command. Violating this assumption is fine in almost all cases, but not when we need to do a re-auth to add a new oauth scope to a user's token. There is likely a more elegant solution to the problem but until then this changes determineBaseRepo to use an existing apiClient.
mislav
approved these changes
May 18, 2020
mislav
left a comment
mislav
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing this!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #914
It is Mislav's and my hypothesis that the failed reauth issue was caused by having multiple
apiClientinstances during a command's lifetime. The secondapiClients are created inside ofdetermineBaseRepo; this PR changesdetermineBaseRepoto just accept a pre-existingapiClient.It was only creating its own to begin with in an attempt to reduce the length of its function
signature and for no other reason.