Repository navigation
Config should load as unmodified - #147
Merged
Merged
Conversation
williammartin
commented
Jan 22, 2024
| uses: golangci/[email protected] | ||
| with: | ||
| version: v1.52 | ||
| version: v1.54 |
Member
Author
There was a problem hiding this comment.
Bumped this because it seemed to resolve some linting errors. cli/cli is already on 1.54+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR relates to cli/cli#8496
Since the config was moved to
go-ghthis bug has been lurking around. The idea behindIsModifiedis that the config file shouldn't be written if only hosts has changed, and vice versa. Unfortunately, if there is a hosts file then on load of the files, the config entry would beSetModifiedas a result of having the hosts being added as an entry.The consequence of this is that any call to
Writewould attempt to write the config file, even if only hosts had changed.This PR sets the top level Config as unmodified to avoid that.
Testing notes
This command should not write to the config file:
You can set the config file as immutable on Mac like so:
and revert it with: