Repository navigation
Conversation
Add IDE type filtering to the banner system so that VS Code-specific features (CLI install, Enable Subagents) don't show non-functional banners on JetBrains IDEs. - Add `ideTypes` property to BannerCardData interface - Add IDE type filtering logic in WelcomeSection.tsx - Mark CLI/Subagents banners as VS Code-only Fixes cline#8725
🦋 Changeset detectedLatest commit: 897cb61 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
JetBrains Plugin tests failed ❌ The changes in this PR are causing test failures in the JetBrains plugin integration. Please review and fix your changes to ensure they work properly with:
Please check the workflow logs for specific test failure details and update your PR accordingly. Branch: |
|
Hi! I see the JetBrains plugin tests failed, but I don't have access to the test logs in the private repo. Could you please share what specific tests are failing or what changes are needed to make this compatible with the JetBrains integration? The changes I made:
Since |
|
Closing this PR because its linked issue #8725 was closed as completed (the underlying problem was resolved). Since the issue is no longer tracked as open work, this PR is no longer actionable in its current form. If this was closed in error, or if you believe the underlying issue is still valid, please feel free to rebase and reopen this PR (or open a fresh one) — happy to take another look. |
2 participants
Summary
Fixes #8725
This PR adds IDE type filtering to the banner system so that VS Code-specific features (CLI install, Enable Subagents) don't show non-functional banners on JetBrains IDEs.
Changes
src/shared/cline/banner.ts: AddedideTypesproperty toBannerCardDatainterface, allowing banners to specify which IDE types they should appear on ("vscode"or"standalone")webview-ui/src/components/chat/chat-view/components/layout/WelcomeSection.tsx: Added filtering logic that checksPLATFORM_CONFIG.typeagainst the banner'sideTypesRoot Cause
The banners were being filtered by OS platform (
windows,mac,linux) but not by IDE type. Since CLI installation and subagents features are only implemented for VS Code (not JetBrains), the banners were appearing but the actions were failing silently or leading to non-existent settings.Test Plan
ideTypes: ["vscode"]only appear in VS Code buildsideTypes: ["standalone"]only appear in JetBrains buildsideTypesappear on all IDE types (existing behavior preserved)Screenshots
N/A - JetBrains testing environment not available, but the filtering logic mirrors the existing OS platform filtering which is well-tested.
Important
Adds IDE type filtering to banner system to hide VS Code-specific banners on JetBrains IDEs.
ideTypesproperty toBannerCardDatainbanner.tsto filter banners by IDE type ("vscode"or"standalone").WelcomeSection.tsxto filter banners based onideTypesandPLATFORM_CONFIG.type.ideTypes: ["vscode"]only appear in VS Code.ideTypes: ["standalone"]only appear in JetBrains IDEs.ideTypesappear on all IDEs.This description was created by
for 897cb61. You can customize this summary. It will automatically update as commits are pushed.