Skip to content
This repository was archived by the owner on Oct 8, 2024. It is now read-only.
This repository was archived by the owner on Oct 8, 2024. It is now read-only.

Configure globally #60

Description

@bytestream

It would be good if we could set global defaults for the configuration, particularly for localisation of Show/Hide

$.fn.hideShowPassword.defaults = {...}

I think it would just be a simple case of adding $.extend({}, $.fn.hideShowPassword.defaults, params) here https://github.com/cloudfour/hideShowPassword/blob/master/hideShowPassword.js#L198

Activity

  1. bytestream commented on Dec 24, 2019

    @bytestream
    Author

    @tylersticka happy to submit a PR if you agree

  2. tylersticka commented on Dec 26, 2019

    @tylersticka
    Member

    @bytestream Sure, sounds good!

  3. bytestream commented on Dec 27, 2019

    @bytestream
    Author

    Sent :)

  4. tylersticka commented on Dec 27, 2019

    @tylersticka
    Member

    @bytestream Your PR (#61) has been merged, and the change is now available in version 2.2.0 of this package. Thank you for your contribution!

  5. bytestream commented on Dec 27, 2019

    @bytestream
    Author

    Awesome! Thanks for the fast turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions