fix(omo-senpi): point the local launcher update hint at bun - #8895
Merged
Merged
Conversation
The generated local `omo` launcher printed `npm i -g omo-ai[@beta]` for `omo update` and carried that npm command as the brand update command, the last surface still steering users to an npm install of omo-ai. It now uses `bun add -g omo-ai[@beta]`, matching the README, the install guide, and senpi's Node.js runtime notice. install.mjs is regenerated from the source. Refs code-yeongyu/senpi#2157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs code-yeongyu/senpi#2157 (tracking issue; senpi side is code-yeongyu/senpi#2158)
What changed
The generated local
omolauncher (packages/omo-senpi/src/install/local-launcher.ts, written byoh-my-openagent installfor a local sibling-store checkout) answeredomo updatewithomo is updated via npm: npm i -g omo-ai[@beta]and carried that npm command as the brandupdate.command. It was the last surface still steering users to an npm install of omo-ai. It now printsomo is updated via bun: bun add -g omo-ai[@beta]and carries the bun command.plugin/scripts/install.mjsis regenerated withnode packages/omo-senpi/plugin/scripts/build-install.mjs(4-line diff, same as the source change).Not changed on purpose: the published launcher (
omo-native/bin/lib/package-paths.js) already answers with the manager that installed omo-ai (npm i -gfor npm installs,bun add -gfor bun installs); switching an npm install's update command to bun would create a second, shadowing install.Why
senpi#2157 makes the engine recommend a clean reinstall with Bun when it runs on Node.js. Every omo install instruction (README, install guide, release notes, package description) is already Bun-first; this aligns the one remaining hint.
QA & Evidence
installLocalLauncher(...)into a temp HOME for a prerelease (5.0.0-0.beta.90) and a stable (5.0.0) version, then the real generated launcher run asnode <tmp-home>/.local/bin/omo update.omo is updated via bun: bun add -g omo-ai@beta(prerelease) /omo is updated via bun: bun add -g omo-ai(stable); temp HOME removed afterwards. Evidence:.omo/evidence/omo-senpi-adapter/20260927-local-launcher-bun-update/launcher-update.json(local, not committed),sha256 a11b1a616e14f5874e599b58e6e9683417742b032696922a900f91cea0c33eda.bun test packages/omo-senpi/src/install/local-launcher.test.ts packages/omo-senpi/src/install/install-senpi-launcher.test.ts10 pass / 0 fail;tsgo --noEmit -p packages/omo-senpi/tsconfig.jsonexit 0.Summary by cubic
The local
omolauncher now tells users to update with bun instead of npm, matching the README, the install guide, and senpi's Node.js runtime notice.omo updatewithnpm i -g omo-ai[@beta]; it now printsbun add -g omo-ai[@beta]and carries that as the brandupdate.command.omo-native/bin/lib/package-paths.js) is left alone since it already answers with the manager that installed omo-ai, and switching an npm install to bun would create a shadowing second install.plugin/scripts/install.mjsis regenerated from the source; CHANGELOG andchanges.mdupdated.Written for commit 0f4544e. Summary will update on new commits.