Repository navigation
Fix the tests - #10
Conversation
For the new normalised hidden file behaviour
For the hidden file behaviours
For info and so we can check against it in our internal tests
|
I see you requested review, feel free to ping me once things are green |
Yeah sorry I forgot/hadn't looked at the BATS stuff failing. |
|
Okay @larsoner all the required tests are green again now. I've left the bats diagnostic thing in as it can help in future and just left it as not required, but I could remote it completely for now if you'd rather? |
This makes it harder to review. I'd at least get it to "fail gracefully" so that things are green instead of part-red -- for example, returning a "neutral" rather than "failed" or "succeeded" status would be preferable |
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Other than not liking the "red on some is okay to merge" LGTM
So we don't fail if we fail
There's not really a neutral in GitHub Actions compared to Travis' Allowed Failures. Best bet would be as I'd done with it not being required so I've skipped it for now. |
2 participants
For the new normalised hidden file behaviour, this shouldn't be merged until version 1.18.0 or greater is released.