Skip to content

Add the skip option - #8

Merged
larsoner merged 9 commits into
masterfrom
peternewman-skip
Jun 3, 2020
Merged

larsoner merged 9 commits into
masterfrom
peternewman-skip

Conversation

@peternewman

Copy link
Copy Markdown
Collaborator

@peternewman
peternewman requested a review from larsoner May 30, 2020 14:54
@peternewman

Copy link
Copy Markdown
Collaborator Author

@per1234 would you mind taking a look at my first new bats test (now it's working)?

@per1234 per1234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@larsoner

larsoner commented Jun 1, 2020

Copy link
Copy Markdown
Member

CIs are failing

@peternewman

Copy link
Copy Markdown
Collaborator Author

CIs are failing

I think this is because @per1234 was testing for buggy behaviour. I expect we should fix the other things he found, then ship the next release then this will come good...

@peternewman

Copy link
Copy Markdown
Collaborator Author

I think this should be merge-able now @larsoner .

@peternewman

Copy link
Copy Markdown
Collaborator Author

Having debugged it (grumble @per1234 😜 ) it's because our behaviour for hidden files in directories has changed.

@larsoner
larsoner merged commit a945b50 into master Jun 3, 2020
@larsoner
larsoner deleted the peternewman-skip branch June 3, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants