Repository navigation
feat(roadmap): add block - #9
Conversation
|
Thanks for your contribution, @michakrapp. I really appreciate it. Before considering merging your PR, I would like to request some changes to the file structure. As you can see, the existing In that case, would you mind moving the |
|
Also, please take care of these warnings/notices |
|
Sure. Tried to replicate your code style and structure. |
You probably have to create the manifest file first, was not sure if you want the build folder in the repo |
Is it the code load the tasks and call the view. have just moved it to its own controller, so that the shortcode and the block both can use it. If you like to have it in |
|
Please
|
|
moved to Model and fixed the shortcode output |
|
Thanks. I'll review and merge soon. Also, if merged and released to the WordPress.org repo, would you like to have your name as one of the contributors? |
| export default function Edit() { | ||
| return ( | ||
| <p { ...useBlockProps() }> | ||
| { __( 'Roadmap – choose a product in the settings if you want', 'easyroadmap' ) } |
There was a problem hiding this comment.
I can also change the text, since you can not choose a product yet.
Would appreciate that. My wp.org name is |
|
Sure |
|
hey 👋 |
|
@mukto90 commenting here, hope that's ok. Since this and other PRs are merged, will you do a release with the new features and fixes? If you want, I would be happy if you include me as contributor for wp. |
2 participants
closes #8
First version without
productsetting.Use the script
npm run build:blocksto build the block.The
/build/folder will be in root (can be adjusted of course).Did not know if you want to have the build folder in the repo.