ValueError: Sample larger than population or is negative #34

Activity

1. hakluke commented on Apr 11, 2019

   

   hakluke

   on Apr 11, 2019

   Collaborator

   More actions

   Hey @Neolex-Security,
   I've also come across this. The error occurs when the targets file is empty. To reproduce:

   luke@b:/tmp$ echo "" > targets.txt
   luke@b:/tmp$ interlace -threads 10 -tL ./targets.txt -c "echo _target_"
   ==============================================
   Interlace v1.3.3	by Michael Skelton (@codingo_)
   ==============================================
   Traceback (most recent call last):
     File "/usr/local/bin/interlace", line 11, in <module>
       load_entry_point('Interlace==1.3.3', 'console_scripts', 'interlace')()
     File "/usr/local/lib/python3.6/dist-packages/Interlace-1.3.3-py3.6.egg/Interlace/interlace.py", line 24, in main
     File "/usr/local/lib/python3.6/dist-packages/Interlace-1.3.3-py3.6.egg/Interlace/interlace.py", line 10, in build_queue
     File "/usr/local/lib/python3.6/dist-packages/Interlace-1.3.3-py3.6.egg/Interlace/lib/core/input.py", line 190, in process_commands
     File "/usr/local/lib/python3.6/dist-packages/Interlace-1.3.3-py3.6.egg/Interlace/lib/core/input.py", line 69, in _replace_variable_for_commands
     File "/usr/lib/python3.6/random.py", line 320, in sample
       raise ValueError("Sample larger than population or is negative")
   ValueError: Sample larger than population or is negative
   luke@b:/tmp$ 
   

   In a way, this is user error as this command wouldn't achieve anything anyway, however it would be nice to catch this exception and display a more descriptive error to avoid confusion.
2. prodigysml

   self-assigned this

   on Apr 11, 2019
3. prodigysml commented on Apr 11, 2019

   

   prodigysml

   on Apr 11, 2019

   Collaborator

   More actions

   I'll try and look into this issue soon.
4. prodigysml commented on Apr 12, 2019

   

   prodigysml

   on Apr 12, 2019

   Collaborator

   More actions

   Thanks for the steps to reproduce @hakluke ! Really helped in finding the issue quickly. Exception will now be raised.
5. codingo

   closed this as completedin #35on Apr 12, 2019
6. codingo commented on Apr 12, 2019

   

   codingo

   on Apr 12, 2019

   Last edited by codingo

   Owner

   More actions

   Hi @Neolex-Security, this is now fixed in 1.3.4 (release tag) - if you update you should no longer have this issue.

   👍React with 👍1Reacted by Neolex