Skip to content

Multithreading does not work on OSX #36

Closed
Closed
Multithreading does not work on OSX#36

Description

@amalmurali47
amalmurali47
opened on Apr 13, 2019

Hi,

When I run like Interlace like this:

interlace -tL targets.txt -threads 20 -c "dirsearch -u _target_ -t 30 -e '' -w wordlist.txt > results.txt" -v

It feels more like:

while read target; do dirsearch [args] > output.txt; done < targets.txt

It seems to run everything sequentially. @hakluke confirms that he also faced the same issue.

Activity

  1. prodigysml commented on Apr 20, 2019

    @prodigysml
    prodigysml
    on Apr 20, 2019
    Collaborator

    Thanks for that! Trying to get my hands on a Mac to test this issue.

  2. hakluke commented on Apr 20, 2019

    @hakluke
    hakluke
    on Apr 20, 2019
    Collaborator

    Hey @amalmurali47 - thanks for making the issue. I did have the same issue on mac so it seems to be OSX related. Unfortunately I also no longer have a mac to test on.

    Do you think you could just paste the output of the following as proof + testbench?

    seq 1 5 > ./test.txt
time interlace -tL ./test.txt -threads 5 -c "sleep _target_"

    When threading works properly, it should take around 5 seconds. If it is single threaded, it will take about 15.

  3. xYantix commented on Apr 20, 2019

    @xYantix
    xYantix
    on Apr 20, 2019
    Contributor

    I have a Macbook. Testing isn't working properly for me tonight. Will try again tomorrow and let you know how I go!

  4. xYantix commented on Apr 21, 2019

    @xYantix
    xYantix
    on Apr 21, 2019
    Contributor

    Interlace

    xYantixs-MacBook-Pro:Interlace xyantix$ seq 1 5 > ./test.txt xYantixs-MacBook-Pro:Interlace xyantix$ time python interlace.py -tL ./test.txt -threads 5 -c "sleep _target_" ============================================== Interlace v1.3.4 by Michael Skelton (@codingo_) ============================================== [10:28:09] [THREAD] [sleep 4] Added to Queue [10:28:09] [THREAD] [sleep 5] Added to Queue [10:28:09] [THREAD] [sleep 2] Added to Queue [10:28:09] [THREAD] [sleep 3] Added to Queue [10:28:09] [THREAD] [sleep 1] Added to Queue

    real 0m15.236s
    user 0m0.055s
    sys 0m0.083s

    Added a picture because the formatting was funky. Looks single threaded though.

  5. prodigysml commented on Apr 21, 2019

    @prodigysml
    prodigysml
    on Apr 21, 2019 via email
    Collaborator

  6. xYantix commented on Apr 21, 2019

    @xYantix
    xYantix
    on Apr 21, 2019 via email
    Contributor

  7. amalmurali47 commented on Apr 22, 2019

    @amalmurali47
    amalmurali47
    on Apr 22, 2019
    ContributorAuthor

    @hakluke: Sure. Here's the output on my machine:

    ➜ seq 1 5 > ./test.txt
➜ time interlace -tL ./test.txt -threads 5 -c "sleep _target_"
==============================================
Interlace v1.3.3	by Michael Skelton (@codingo_)
==============================================
[13:52:39] [THREAD] [sleep 4] Added to Queue
[13:52:39] [THREAD] [sleep 5] Added to Queue
[13:52:39] [THREAD] [sleep 2] Added to Queue
[13:52:39] [THREAD] [sleep 3] Added to Queue
[13:52:39] [THREAD] [sleep 1] Added to Queue
interlace -tL ./test.txt -threads 5 -c "sleep _target_"  
0.17s user 
0.09s system 
1% cpu 
15.278 total

  8. Emxm3 commented on Apr 30, 2019

    @Emxm3
    Emxm3
    on Apr 30, 2019
    Contributor

    Using @xYantix's macbook and confirmation from he himself, we've fixed the issue with the multi-threading on OSX.

  9. Emxm3 commented on Apr 30, 2019

    @Emxm3
    Emxm3
    on Apr 30, 2019
    Contributor

    (Yay, my first pull request evarrrr!)

  10. hakluke commented on Apr 30, 2019

    @hakluke
    hakluke
    on Apr 30, 2019
    Collaborator

    Phwoar nice work dudes!

  11. codingo
    closed this as completedon Apr 30, 2019

  12. xYantix commented on Apr 30, 2019

    @xYantix
    xYantix
    on Apr 30, 2019
    Contributor

    Interlace

    Working nicely on my machine now! Mac OS 10.14.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions