Repository navigation
Removed [Thread] statements when --silent is present - #29
Merged
Merged
Conversation
codingo
reviewed
Feb 6, 2019
codingo
left a comment
codingo
left a comment
Owner
There was a problem hiding this comment.
I haven't tested this (on mobile), but has this been tested? I believe this should be wrapped around the print statement and not the if conditional to avoid throwing an exception?
Owner
Owner
|
Actually, I see the indent applies there also. Missed first pass. If you can confirm tested, will merge. |
Collaborator
Author
|
Yes tested
…On Wed, 6 Feb. 2019, 7:53 pm Michael Skelton ***@***.*** wrote:
Actually, I see the indent applies there also. Missed first pass. If you
can confirm tested, will merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQNZ04D83JjxEXfS-4wFw80Hdug078p8ks5vKpglgaJpZM4aknT5>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve issue #28