Repository navigation
feat: add session attention and orchestration parity - #422
Merged
Merged
Conversation
|
Too many files changed for review (717 files, 100 file limit). |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedToo many files! This PR contains 592 files, which is 292 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (107)
📒 Files selected for processing (592)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Checkpoint via cy-loop-tasks (iteration 2, phase B mode=tasks). Co-Authored-By: Codex <[email protected]>
Checkpoint via cy-loop-tasks (iteration 3, phase B mode=tasks). Adds live attention settings, truthful operator notification delivery, agent-managed surfaces, docs, contracts, and focused race-tested coverage. Co-Authored-By: Codex <[email protected]>
Checkpoint via cy-loop-tasks (iteration 4, phase B mode=tasks). Co-Authored-By: Codex <[email protected]>
Checkpoint via cy-loop-tasks (iteration 10, phase D review round 1). Completes Task 08 QA, resolves every final deep-review finding, and records clean teardown evidence. Co-Authored-By: Codex <[email protected]>
pedronauck
force-pushed
the
herdr-parity
branch
from
August 17, 2026 17:13
07b656e to
505f32f
Compare
This was referenced Aug 17, 2026
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 27, 2026
Merged
Merged
This was referenced Sep 7, 2026
Merged
Merged
Merged
This was referenced Sep 15, 2026
Merged
Merged
This was referenced Sep 27, 2026
Merged
Merged
This was referenced Oct 6, 2026
Merged
Merged
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
This closes the Herdr parity spec as one end-to-end runtime, Web, docs, and QA change. The broad Northstar companion scenario remains explicitly blocked by the pre-existing autonomous-progress issue documented in
BUG-20260719-autonomous-progress-unobservable; it is not counted as a Herdr pass.Runtime and public contracts
Web and desktop shell
donebehavior by reporting presence only while the session window and browser document are focused and visible.Docs and operator guidance
skills/compozy/references for native tools, runtime operations, configuration, orchestration, and window management.Final review remediation
One full-diff Codex review covered 627 selected files and 1,944 selected hunks. Its two defects and two advisories are all resolved:
muted_workspaceswrites serialize as[];Release Notes
🎉 Features
🐛 Bug Fixes
📚 Documentation
QA
Final Status: Herdr parity QA and workstream closure pass. The single deep-review round is fully remediated, the full gate is current, and teardown is clean.
Coverage: 34/34 charter matrix rows settled across 30 unique scenarios, covering attention, accessibility, done/presence, interaction recovery, orchestration, settings, shortcuts, keyboard navigation, hooks, and the task-approval canary.
Issues: 1 Herdr Blocks-Completion issue found and fixed; Data-Loss: 0, Trust-Damage: 0, Friction: 0, Cosmetic: 0. One pre-existing product-wide Northstar blocker remains outside this workstream.
Evidence:
Cross-workspace Needs you landing:
Finished session and presence clearing:
Final quiet attention state:
Blocked / needs human: None for the Herdr parity contract. Native OS notification presentation was outside browser-run evidence; the real unavailable state and deterministic granted/denied branches were verified. The Northstar companion remains blocked by the registered autonomous-progress issue.
Full report:
2026-08-16-herdr-parity.mdHow you verified it
make gate— passed after review remediation; the diff escalated to the completemake verifypipeline.make gate-full— exit 0 with current full-gate fingerprint9bef532f0d46acf0a6263cc5cbce5224df06dfbf; log.cache/gate/logs/full-1786937400.log.make test-e2e-runtime— passed.make test-e2e-web— 180 passed, 3 skipped, 0 failed.-race.clean: true,survivors: [].Impact
Compozy Impact Audit:
compozy__session_wait,compozy__session_spawn,compozy__session_stop,compozy__session_approve,compozy__session_clarify_answer,compozy__session_prompt_cancel, andcompozy__notify, including descriptors, input/output schemas, digests, risk flags, capability gates, availability diagnostics, and CLI/API fallbacks.session_attention_changedhook contract, ACP/wake fixtures, extension descriptors, tool/resource registry wiring, and live config lifecycle for[attention],[shell.sessions], and[window_manager.shortcuts]. No compatibility aliases or dual fields are retained.workspace_id; list/read/cursor/SSE/Web cache paths and native/CLI routes enforce workspace ownership. Loop environment projections use workspace-scoped compound identity and reopen coverage.skills/compozy/for public tool IDs, wait/stop/cancel semantics, configuration shapes, orchestration, and effective keymap behavior.web/, shared UI primitives, Storybook contracts, Playwright coverage,packages/site, generated CLI references, OpenAPI, and both SDKs.make gatepasses locally (make gate-fullbefore review on larger changes)