Repository navigation
fix: enable prompts for managed sessions - #517
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (7)
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review. WalkthroughChangesSession prompt eligibility now supports public session types: Session control eligibility
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The Web now permits prompts for eligible managed sessions while keeping destructive lifecycle actions restricted and preserving existing workspace-scoped validation. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation The changes support issue Full details: Out of Scope Changes checkExplanation The PR objectives include adding emojibase peer-dependency declarations in web/package.json and packages/ui/package.json. These maintenance changes are unrelated to issue Resolution Remove the unrelated emojibase dependency changes from this PR, or link them to a separate issue and submit them separately. If they must remain, provide reviewable evidence for the excluded package.json files and explain their direct connection to issue
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
bdcc4e1 to
605dc74
Compare
|
| Filename | Overview |
|---|---|
| web/src/systems/session/lib/session-running.ts | Defines explicit public-session prompt eligibility while retaining read-only handling for transitional, archived, dream, and unrecoverable sessions. |
| web/src/hooks/routes/use-session-page-controls.ts | Broadens prompt and busy-input controls to eligible managed sessions while adding user-authority guards to lifecycle mutations. |
| web/src/systems/os/apps/session/session-window-content.tsx | Rewires composer Stop generation to cancel only the active prompt rather than stopping the entire session. |
| web/src/systems/session/hooks/use-session-topbar-slot.tsx | Restricts lifecycle primary and overflow actions to user-controllable sessions. |
| web/package.json | Adds the exact peer package required by the existing emojibase-data development dependency. |
| packages/ui/package.json | Adds the same exact peer dependency for the shared UI workspace. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
S[Public session] --> T{Session type}
T -->|user| P[Prompt controls]
T -->|system / coordinator / spawned| P
T -->|dream / maintenance / missing| R[Read-only]
P --> A{Lifecycle authority}
A -->|user| L[Rename / clear / attach / archive / delete / stop session]
A -->|managed| N[Lifecycle actions unavailable]
P --> B[Send / queue / steer / interrupt / stop generation]
Reviews (1): Last reviewed commit: "build: declare emojibase peer dependency" | Re-trigger Greptile
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This branch was successfully deployed
1 participant
What & why
Fixes #507.
The Web composer now follows prompt authority instead of user-owned lifecycle authority. Public
user,system,coordinator, andspawnedsessions can be prompted when active or stopped; active sessions expose Queue, Steer, Interrupt, and Stop generation. Stopped managed sessions resume under the same durable session ID and transcript.Managed sessions still cannot be renamed, cleared, attached, archived, deleted, or stopped as a whole. Dream, maintenance, archived, transitional, and unrecoverable sessions remain read-only.
The first PR run also reproduced an existing Linux CI failure from
main:[email protected]was declared without its requiredemojibasepeer. The two direct consumer workspaces now declare[email protected], which makes the clean Bun dependency graph complete.Codex co-wrote this change; I reviewed the diff and verified it locally and through a real provider-backed browser walk.
How you verified it
make gate— PASS at fingerprint469392316bd6225af372af2afae61d4047dda89d(go-lint, race-enabledgo-test, all-workspace JS lint/typecheck/test)make codegen-check— PASS after the peer-dependency repairclean: true, no surviving processesDurable QA report:
docs/qa/reports/2026-09-01-issue-507-managed-session-prompts.md.Impact
webandpackages/uideclare the peer required by their existingemojibase-datadevelopment dependency; no runtime package or version changes.config.tomlchange.make gatepasses locally; this PR is delivered only after its required CI checks are greenSummary by CodeRabbit