fix: hide internal Goal prompts from the operator queue - #618

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
compozy-site	Ready	Preview	Sep 11, 2026 8:12pm UTC

No actionable comments were generated in the recent review. 🎉

Walkthrough

Goal-owned session inputs are hidden from operator queue reads and summaries. Operator clear and mutation operations leave Goal-owned entries unchanged. Session generation rebasing preserves queued Goal entries, and tests update ownership expectations.

Changes

Goal queue visibility and preservation

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 532a7

No concrete merge-blocking risk remains in the reviewed changes.

• Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

React Doctor found no new issues. 🎉

_{Reviewed by React Doctor for commit 532a748.}

Confidence Score: 5/5

The PR appears safe to merge; the latest changes strengthen handler regression coverage without introducing a new actionable defect.

Goal-owned rows are consistently excluded from public reads and mutations while current-generation queued Goal work remains eligible after clear advances the generation. No outstanding previous finding or accepted new issue was identified.

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Session input queue] --> B{owner_kind}
    B -->|goal| C[Internal Goal work]
    B -->|other or null| D[Public operator queue]
    C --> E[Hidden from lists and counts]
    C --> F[Protected from queue mutations]
    C --> G[Rebased across clear generation]
    D --> H[Visible to operators]
    D --> I[Eligible for clear and direct actions]

_{Reviews (3): Last reviewed commit: "test: verify stopped-session queue respo..." | Re-trigger Greptile}

@coderabbitai Please identify the exact file and function names counted by the Docstring Coverage warning (0%, two analyzed functions, two unsupported). We are addressing all findings, including this warning. CancelSessionInput already has a Go doc comment, while ClearSessionInputs is missing one; the changed TypeScript content consists of test/story fixture ownership values. Please clarify which supported functions contribute to the denominator so we can fix the actual gap without documenting unrelated helpers or generated sqlc output.

#!/bin/bash
set -euo pipefail

echo '=== PR comments and reviews mentioning docstring/coverage ==='
gh api repos/compozy/compozy/issues/618/comments --paginate \
  --jq '.[] | select((.body // "") | test("(?i)docstring|coverage|unsupported")) | {user: .user.login, url: .html_url, body: .body}'
gh api repos/compozy/compozy/pulls/618/comments --paginate \
  --jq '.[] | select((.body // "") | test("(?i)docstring|coverage|unsupported")) | {user: .user.login, url: .html_url, path: .path, line: .line, body: .body}'
gh api repos/compozy/compozy/pulls/618/reviews --paginate \
  --jq '.[] | select((.body // "") | test("(?i)docstring|coverage|unsupported")) | {user: .user.login, url: .html_url, body: .body}' || true

echo '=== PR checks ==='
gh pr checks 618 --repo compozy/compozy --json name,state,link,workflow 2>/dev/null || true

echo '=== Changed files ==='
gh pr view 618 --repo compozy/compozy --json files \
  --jq '.files[] | {path: .path, additions: .additions, deletions: .deletions}'

echo '=== Candidate configuration files ==='
fd -HI -t f '(^|/)(coderabbit\.ya?ml|\.coderabbit\.ya?ml|.*[Dd]ocstring.*|.*[Cc]overage.*|.*[Rr]eview.*)$' . \
  -E .git -E node_modules -E vendor || true

echo '=== Changed non-generated Go declarations and doc comments ==='
for f in \
  internal/api/httpapi/handlers_test.go \
  internal/store/globaldb/global_db_session_input_clear.go \
  internal/store/globaldb/global_db_session_input_queue_terminal.go \
  internal/store/globaldb/global_db_session_input_queue_test.go
do
  if [ -f "$f" ]; then
    echo "--- $f ---"
    ast-grep outline "$f" --items all --type function --view expanded || true
    rg -n -C2 '^(//.*|func\s+)' "$f" || true
  fi
done

#!/bin/bash
set -euo pipefail

echo '=== Changed declaration lines in PR patch ==='
gh pr diff 618 --repo compozy/compozy --patch | \
  awk '
    /^\+\+\+ b\// { file=substr($0, 7) }
    /^@@/ { hunk=$0 }
    /^[+-][^+-]/ && /(func[[:space:]]+\(|func[[:space:]]+[[:alnum:]_]+|function[[:space:]]|const[[:space:]]+[[:alnum:]_]+[[:space:]]*=[[:space:]]*\(|export[[:space:]].*(function|=>))/ {
      print file "\t" hunk "\t" $0
    }'

echo '=== Full diffs for candidate Go files ==='
git diff --unified=80 'origin/main...HEAD' -- \
  internal/store/globaldb/global_db_session_input_clear.go \
  internal/store/globaldb/global_db_session_input_queue_terminal.go || \
gh pr diff 618 --repo compozy/compozy --patch | sed -n '/^diff --git a\/internal\/store\/globaldb\/global_db_session_input_clear.go /,/^diff --git /p; /^diff --git a\/internal\/store\/globaldb\/global_db_session_input_queue_terminal.go /,/^diff --git /p'

echo '=== CodeRabbit configuration ==='
if [ -f .coderabbit.yaml ]; then
  cat -n .coderabbit.yaml
elif [ -f .coderabbit.yml ]; then
  cat -n .coderabbit.yml
else
  echo 'No root CodeRabbit configuration file found.'
fi

echo '=== Repository references to Docstring Coverage ==='
rg -n -i -C3 'docstring[ _-]*coverage|docstring' \
  --glob '!node_modules/**' --glob '!vendor/**' --glob '!**/sqlcgen/**' . \
  || true

@pedronauck You are correct to request the exact denominator.

I cannot identify the two analyzed functions from the emitted check output. The Docstring Coverage check reports only aggregate counts. The resolved configuration specifies the threshold and warning mode. It does not expose per-function results.

The available diff evidence shows:

• internal/store/globaldb/global_db_session_input_clear.go: (*SessionRepo).ClearSessionInputs changed only in its body. It has no Go doc comment.
• internal/store/globaldb/global_db_session_input_queue_terminal.go: (*SessionRepo).CancelSessionInput changed only in its body. It already has the valid doc comment: // CancelSessionInput cancels one pending queue entry.
• internal/store/globaldb/sqlcgen/session_input_clear.sql.go: (*Queries).RebasePreservedSessionInputs is the only changed Go function declaration. This file is generated sqlc output and should not receive a manual doc comment.
• The two unsupported files are consistent with the two changed SQL files: internal/store/globaldb/queries/session_input.sql and internal/store/globaldb/queries/session_input_clear.sql.

Therefore, I cannot substantiate that CancelSessionInput contributes an undocumented function, or that documenting ClearSessionInputs will resolve this aggregate warning. Do not document the TypeScript test/story fixtures or generated sqlc output for this warning. The warning is non-actionable until the check reports its analyzed symbols.

You are interacting with an AI system.

@coderabbitai Addressed the second-round findings:

1. Minor, successful stopped-session queue read: fixed in 532a748047250db1f75b381f995dd492bda4da98. The existing handler subtest now supplies sentinel input/summary data, decodes the response, checks entry identity/text/status and summary values, and asserts exactly one queue read and one summary read. The status assertion and storage-error short-circuit checks remain. Focal race validation passed: CGO_ENABLED=1 go test -race -gcflags='modernc.org/...=-d=checkptr=0' -p 2 -parallel 4 -timeout 5m ./internal/api/httpapi -run TestSessionInputHandlersExposeAuthoritativeQueueMutations (1.086s). No broad local lane was run; CI owns it at the user's request.

2. Linked Issues / impact audit evidence: the required entry is committed and was preserved alongside Fix beta.25 session deletion failure and repeated stopped-session queue errors #613 when main advanced. Direct current-head link: https://github.com/compozy/compozy/blob/532a748047250db1f75b381f995dd492bda4da98/docs/_memory/change-impact.md#issue-615--hide-internal-goal-queue-rows . The unchanged repository filter excludes Markdown from automatic assessment; here is the reviewable content:

• Native tools and CLI: compozy__session_inputs_list, compozy__session_inputs_clear, and session input list|clear share the store's operator population with HTTP/UDS. compozy__session_input_cancel uses the protected remove path; compozy__session_input_replace|promote retain their ownership checks. Goal-owned rows are omitted from queue lists and queue.entries; direct remove rejects Goal IDs. Existing replace/promote ownership restrictions remain. Goal controls and dispatcher selection retain their own paths.
• Extensibility/hooks/config: Extension sessions/inputs/list receives the same filtered rows; mutation protections are shared. No DTO, tool ID, hook, config, or SDK shape changes.
• Workspace data isolation: The query remains session-scoped behind existing workspace authorization. Clear atomically cancels and traces only public queued inputs; dispatching rows and current-generation queued Goals carry forward to the new input generation so Goals remain eligible. Stale queued Goals are not revived. Goal fencing/terminal state is untouched; no schema migration or user-state loss. Attachment retention uses the same list; Goal prompts carry no attachments.
• Official Compozy skill: Runtime operations and extension-authoring references describe the internal Goal exclusion and dedicated lifecycle controls.
• Web/Docs/compatibility: Generic owner attribution remains for other actors; Goal-owned strip fixtures become agent-owned. This restores the pre-beta.23 public queue contract after feat: manageable session queue, truthful live view, and legible transcripts #557 removed the owner filter, without a DTO change or compatibility shim. RT-019 owns the focused clear/list/dispatch QA; RT-059 receives the queue-strip expectation.

3. Repeated aggregate Docstring Coverage warning: the relevant production/test declarations and generated SQL are unchanged from the first review. Your evidence-based withdrawal still applies: fix: hide internal Goal prompts from the operator queue #618 (comment) . No symbols were supplied to substantiate the denominator. Please retain that disposition rather than introducing unrelated comments or hand-editing generated code.

Please verify these dispositions on the current head. All severities, including outside-diff suggestions and general pre-merge checks, are included in this response.

#!/bin/bash
set -euo pipefail

echo '=== Current HEAD ==='
git rev-parse HEAD
git show -s --format='%H%n%s' HEAD

echo '=== Handler test outline and relevant queue-read assertions ==='
ast-grep outline internal/api/httpapi/handlers_test.go --items all --type function --match 'TestSessionInputHandlersExposeAuthoritativeQueueMutations' --view expanded
rg -n -C 8 'persisted follow-up|inq-stopped|ListPendingSessionInputs|ListSessionInputQueueSummary|authoritative queue|stopped-session|stopped session' internal/api/httpapi/handlers_test.go

echo '=== Impact audit entry ==='
rg -n -A 80 -B 3 '^##? Issue 615|issue-615|Hide internal Goal queue rows|internal Goal' docs/_memory/change-impact.md

echo '=== Current declarations and docs ==='
rg -n -C 3 '^// (ClearSessionInputs|CancelSessionInput)|func \(.*\) (ClearSessionInputs|CancelSessionInput)\b' \
  internal/store/globaldb/global_db_session_input_clear.go \
  internal/store/globaldb/global_db_session_input_queue_terminal.go

echo '=== CodeRabbit review comments and thread resolution state ==='
gh api graphql -F owner='compozy' -F name='compozy' -F number=618 -f query='
query($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    pullRequest(number: $number) {
      reviewThreads(first: 100) {
        nodes {
          isResolved
          path
          comments(first: 20) {
            nodes { author { login } body url }
          }
        }
      }
    }
  }
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] |
  select(any(.comments.nodes[]?; (.author.login == "coderabbitai" or .author.login == "coderabbitai[bot]") and (.body | test("stopped-session|stopped.session|Docstring Coverage|Linked Issues|impact audit"; "i")))) |
  {isResolved, path, comments: [.comments.nodes[] | {author: .author.login, url, body}]}'

#!/bin/bash
set -euo pipefail

echo '=== Complete stopped-session subtest ==='
sed -n '2919,2988p' internal/api/httpapi/handlers_test.go

echo '=== Locate impact-audit documentation in checkout ==='
fd -HI -t f 'change-impact\.md$|.*impact.*\.md$' . -E .git -E node_modules -E vendor || true
rg -n -i -C 4 'issue[ -]615|hide internal goal queue rows|internal goal exclusion' \
  -g '*.md' -g '!node_modules/**' -g '!vendor/**' . || true

echo '=== Referenced document at verified commit ==='
gh api repos/compozy/compozy/contents/docs/_memory/change-impact.md \
  -f ref='532a748047250db1f75b381f995dd492bda4da98' \
  --jq '.content' 2>/dev/null | base64 --decode | \
  awk '/^## Issue 615 — Hide internal Goal queue rows/{show=1} show{print} /^## / && !/^## Issue 615 — Hide internal Goal queue rows/{exit}' \
  || echo 'The referenced documentation path could not be retrieved.'

echo '=== Relevant CodeRabbit review threads ==='
gh api graphql -F owner='compozy' -F name='compozy' -F number=618 -f query='
query($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    pullRequest(number: $number) {
      reviewThreads(first: 100) {
        nodes {
          id
          isResolved
          path
          comments(first: 20) {
            nodes { author { login } body url }
          }
        }
      }
    }
  }
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] |
  select(any(.comments.nodes[]?; .author.login == "coderabbitai" and (.body | test("stopped[ -]session|Docstring Coverage|Linked Issues|impact audit"; "i")))) |
  {id, isResolved, path, comments: [.comments.nodes[] | {author: .author.login, url, body}]}' || true

#!/bin/bash
set -euo pipefail

sha='532a748047250db1f75b381f995dd492bda4da98'

echo '=== Remote commit tree matches claimed audit path ==='
gh api "repos/compozy/compozy/git/trees/$sha?recursive=1" --paginate \
  --jq '.tree[] | select(.path == "docs/_memory/change-impact.md" or (.path | test("change-impact|impact"; "i"))) | {path, type, sha}' || true

echo '=== Raw Contents API response for claimed path ==='
gh api -i "repos/compozy/compozy/contents/docs/_memory/change-impact.md?ref=$sha" 2>&1 | sed -n '1,80p' || true

echo '=== All CodeRabbit-authored PR review threads ==='
gh api graphql -F owner='compozy' -F name='compozy' -F number=618 -f query='
query($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    pullRequest(number: $number) {
      reviewThreads(first: 100) {
        nodes {
          id
          isResolved
          path
          comments(first: 20) {
            nodes { author { login } body url }
          }
        }
      }
    }
  }
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] |
  select(any(.comments.nodes[]?; (.author.login | test("coderabbit"; "i")))) |
  {id, isResolved, path, comments: [.comments.nodes[] | {author: .author.login, url, body: (.body | .[0:500])}]}' || true

echo '=== CodeRabbit top-level issue comments ==='
gh api 'repos/compozy/compozy/issues/618/comments?per_page=100' --paginate \
  --jq '.[] | select(.user.login | test("coderabbit"; "i")) | {url: .html_url, body: (.body | .[0:800])}' || true

@pedronauck Verified on current HEAD 532a748047250db1f75b381f995dd492bda4da98.

• The stopped-session queue-read finding is addressed. internal/api/httpapi/handlers_test.go now verifies the successful queue response data, queue summary, and both read counts. It also retains the masked-error and summary-read short-circuit checks.
• The Issue #615 impact audit exists in docs/_memory/change-impact.md at the stated commit. It covers native tools, CLI, extension behavior, workspace isolation, Goal lifecycle behavior, official skill guidance, web fixtures, compatibility, and QA ownership.
• The aggregate Docstring Coverage warning remains withdrawn. The check still provides no supported function names for its denominator. No unrelated comment or generated sqlc change is justified.

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

You are interacting with an AI system.

Delivery verified on 532a748047250db1f75b381f995dd492bda4da98.

• Full CI passed: 32 successful checks, including Verify, all eight Go race shards, frontend, runtime/desktop E2E, all four web E2E shards, and the E2E aggregate. No pending or failing checks; 17 conditional release/nightly jobs were skipped by their workflow conditions.
• CodeRabbit approved this head and confirmed every disposition: the minor stopped-session response test finding is fixed, the required impact audit is verified, and the unsubstantiated aggregate docstring warning remains withdrawn.
• Greptile completed review 3 on this head with confidence 5/5 and no outstanding findings. React Doctor reported no new issues on this head. All review/comment/thread pages were collected; zero inline or unresolved review threads remain.
• The focused handler race suite passed after remediation (1.086s). The real isolated-daemon evidence remains in the QA report. Broad local gates were delegated to CI at the user's request.

The PR is open, ready for review, conflict-free against main, and has not been merged.