fix: discover Claude reasoning options for each exact model - #658

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
compozy-site	Ready	Preview	Sep 18, 2026 2:15am UTC

No actionable comments were generated in the recent review. 🎉

Walkthrough

The change adds per-model ACP inspection and confirmation, preserves exact Claude transport identities, stores transport configuration snapshots, and propagates reasoning metadata through catalog, session, persistence, and runtime-selector layers.

Changes

ACP inspection and confirmation

Canonical identity and catalog discovery

Catalog merge and persistence

Runtime reasoning state and selector presentation

Session capability hydration

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Bug fix · Severity of issue fixed: Medium

Sequence Diagram(s)

sequenceDiagram
  participant ACP
  participant ModelCatalog
  participant GlobalDB
  participant SessionRuntime
  participant RuntimeSelector
  ACP->>ModelCatalog: inspect model-specific options
  ModelCatalog->>GlobalDB: persist transport binding snapshots
  GlobalDB->>SessionRuntime: restore reasoning metadata
  SessionRuntime->>RuntimeSelector: provide effective model capabilities
  RuntimeSelector->>SessionRuntime: submit selected effort
  SessionRuntime->>ACP: apply and confirm selected effort

Merge Risk: 🟡 Moderate · up to de400

Some model selections can be validated against the wrong transport configuration, and models without a reasoning control can be displayed as having reasoning enabled. Correct both capability-state mismatches before merging.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

React Doctor found no new issues. 🎉

_{Reviewed by React Doctor for commit 6efe3b5.}

Confidence Score: 4/5

The implementation has no newly identified code defect, but the repository’s required application-level QA remains incomplete and must be satisfied before merging.

Findings

1.  Required QA Remains Pending ▶

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[ACP provider advertises models] --> B[Disposable inspection session]
    B --> C[Select each exact transport model]
    C --> D[Capture model-specific config options]
    D --> E[Map transport ID to preserved logical identity]
    E --> F[Persist binding and complete option snapshot]
    F --> G[Project reasoning_known and reasoning_apply]
    G --> H[Web shows controls for effective model]
    H --> I[Session applies model then effort]
    I --> J{Provider readback matches request?}
    J -->|Yes| K[Publish applied runtime state]
    J -->|No| L[Preserve intent and report negotiation failure]

_{Reviews (6) · Last reviewed commit: "docs: resolve change impact conflict wit..."}

Isolated application evidence: exact Fable 5.1 is selected in the full list and recent/favorites, starred, with Low retained after browser reload and a lab-daemon restart. Fable 5 remains a separate identity. The stale-source banner is intentional: discovery returned account HTTP 429 and preserved the last valid capability snapshot.

The installed adapter separately acknowledged low/high and completed a real Fable 5.1 prompt. The application prompt still fails explicitly on the account's HTTP 429; selected Low is not represented as applied. Full application recovery and final-head CI/review evidence remain pending.

@coderabbitai Please assess the explicit dispositions below, especially the distinction between matrix coordinates and post-selection ACP controls.

Follow-up on review 5226811054 (including its collapsed/out-of-diff findings):

• Binding-selection validation (major): after tracing the released extension contract, the proposed replacement is not valid. ModelSourceRow.ConfigOptions declares the logical configuration-matrix dimensions; ModelSourceTransportBinding.OptionSelections selects a supported transport using those dimensions. The newly stored binding ConfigOptions is the ACP control snapshot after that transport is selected. These are different domains. Live ACP discovery does not create OptionSelections; extension mappings do not expose the new per-binding snapshot field. See internal/extension/contract/model_source.go and modelSourceTransportBindings in internal/extension/model_source_options.go. Existing SQLite foreign keys deliberately preserve the logical coordinate contract. The round-trip regression now includes a context=standard matrix coordinate and a separate post-selection effort=low control, preserving both without weakening any constraint. Proposed disposition: invalid cross-domain validation; comments clarify ownership. Please confirm.
• Default-runtime effect (nitpick): the redundant object dependency is removed: synchronization now depends on the server agent/effective input, and derives the default inside the effect. This effect synchronizes the external XState store consumed by imperative prompt snapshots, consistent with React's external-system effect contract: https://react.dev/reference/react/useEffect. It does not mirror local React derived state. Removing the synchronization would leave getSessionPromptRuntimeSnapshot stale. The canonical hook tests pass; this remains subject to the next React Doctor run.
• Generated contract coverage: the current-head GitHub Preflight (codegen + installer + language) check passed at 5511164: https://github.com/compozy/compozy/actions/runs/35134230514. It independently verifies regeneration, including excluded OpenAPI/Web/SDK generated files. No generated contract changes are planned in the follow-up batch.
• Docstring warning: added behavioral documentation to touched production and canonical test functions; awaiting the next coverage result, not claiming the threshold passed yet.

Additional isolated rendered walkthrough on code head fac7fe1:

• Fable 5.1 Low → Sonnet 5 retained Low; selecting Haiku cleared effort and removed the slider; selecting the Fable favorite restored its advertised High default.
• From Low, rapid End/Home/ArrowRight input accepted Max and temporarily disabled further selection during persistence. Public readback and browser reload retained Max (no out-of-order replacement).
• At a 390×844 viewport, the 320-pixel picker stays inside the viewport without horizontal page overflow, and the reasoning control remains visible.

Provider acknowledgement through the application and the real queued-prompt/recovery walk remain incomplete. The direct minimal adapter control confirmed the account's Fable usage limit; a later application retry also returned a native authentication-resolution failure. The application retains selected intent without claiming it was applied.

@coderabbitai review

The final documentation head is 9f8c20f; production code is unchanged from fac7fe1. The last completed review still covers 5511164, while the fac7fe1 processing marker disappeared after the documentation push and no completed review of that code was published. Please complete coverage of the unreviewed remediation, including empty-snapshot preservation, absent-policy semantics, hook simplification and touched-function documentation.

Please also explicitly assess the two out-of-diff/nitpick dispositions in #658 (comment). We are retaining the real-provider QA blocker and are not asking for a delivery-complete or merge approval.

#!/bin/bash
set -euo pipefail

ast-grep outline internal/extension/contract/model_source.go --items all
ast-grep outline internal/extension/model_source_options.go --items all
ast-grep outline internal/store/globaldb/global_db_model_catalog_bindings.go --items all
ast-grep outline internal/modelcatalog/live_sources_acp.go --items all
ast-grep outline web/src/systems/session/hooks/use-session-prompt-runtime.ts --items all
ast-grep outline web/src/systems/session/hooks/__tests__/use-session-prompt-runtime.test.tsx --items all

printf '\n=== Contract and extension binding mapping ===\n'
sed -n '/type ModelSourceRow/,/^}/p; /type ModelSourceTransportBinding/,/^}/p' internal/extension/contract/model_source.go
rg -n -A70 -B15 '\bmodelSourceTransportBindings\s*\(' internal/extension/model_source_options.go

printf '\n=== Binding persistence and schema ===\n'
rg -n -A160 -B15 '\b(normalizeModelCatalogTransportBindings|insertModelCatalogTransportBindings|modelCatalogTransportBindingFromGenerated)\b' internal/store/globaldb/global_db_model_catalog_bindings.go
sed -n '/CREATE TABLE model_catalog_transport_bindings/,/);/p' internal/store/globaldb/schema/definitions/36_model_catalog.sql
cat internal/store/globaldb/schema/migrations/00120_schema.sql

printf '\n=== ACP model mapping ===\n'
rg -n -A180 -B20 '\b(listACP|applyACPModelReasoning|modelOptionDescriptors)\b' internal/modelcatalog/live_sources_acp.go

printf '\n=== Prompt runtime hook and tests ===\n'
sed -n '1,300p' web/src/systems/session/hooks/use-session-prompt-runtime.ts
rg -n -A140 -B20 'config_option_update|promptRuntimeDefaults|effectiveRuntime' web/src/systems/session/hooks/__tests__/use-session-prompt-runtime.test.tsx

printf '\n=== Current commit and codegen workflow status, if available ===\n'
git rev-parse HEAD
gh run view 35134230514 --repo compozy/compozy --json status,conclusion,headSha,name,event,url 2>&1 || true

#!/bin/bash
set -euo pipefail

printf '\n=== Binding selection normalization and database constraints ===\n'
rg -n -A145 -B15 '\bnormalizeModelCatalogBindingSelections\s*\(' internal/store/globaldb
rg -n -A120 -B10 'model_catalog_transport_binding_selections|FOREIGN KEY.*option' internal/store/globaldb/schema internal/store/globaldb/queries

printf '\n=== Runtime capability overlay completion ===\n'
sed -n '260,345p' web/src/systems/session/hooks/use-session-prompt-runtime.ts

printf '\n=== Reasoning policy merge and coverage ===\n'
sed -n '1,260p' internal/modelcatalog/reasoning_merge.go
rg -n -A130 -B15 'absent reasoning policy|empty binding|ReasoningApply' internal/modelcatalog/service_test.go

printf '\n=== Changed production/test function documentation ===\n'
git diff --unified=3 551116428139e543609ed4c843e6f355ee9cc327..HEAD -- \
  'internal/**/*.go' 'web/src/**/*.ts' 'web/src/**/*.tsx' | \
  rg -n -C2 '^\+(\s*//|/\*\*|\s*\*|\s*(export )?func |.*=>|.*\bfunction\b)' || true

printf '\n=== CI jobs for the cited run ===\n'
gh run view 35134230514 --repo compozy/compozy --json conclusion,jobs,name,status,url

printf '\n=== Current PR changed files ===\n'
gh pr view 658 --repo compozy/compozy --json headRefOid,files,statusCheckRollup 2>&1 || true

@pedronauck Confirmed. The binding-selection finding was based on an incorrect cross-domain assumption.

• ModelSourceRow.ConfigOptions defines logical configuration-matrix coordinates.
• ModelSourceTransportBinding.OptionSelections selects a transport binding through those coordinates.
• The new ModelTransportBinding.ConfigOptions field stores the ACP control snapshot after transport selection.
• internal/extension/model_source_options.go validates OptionSelections against the row-level matrix options.
• internal/store/globaldb/global_db_model_catalog_bindings.go keeps that validation and persists the ACP snapshot separately as config_options_json.
• Live ACP discovery populates binding ConfigOptions only. It does not create OptionSelections.

The existing foreign keys correctly apply to matrix selections. They must not validate post-selection ACP controls. The context=standard and effort=low round-trip case preserves the required separation. I withdraw the binding-selection validation finding.

The default-runtime effect disposition is also valid. The effect writes server-derived defaults into the external XState store. getSessionPromptRuntimeSnapshot reads that store outside React rendering. The effect is therefore required. The derived-object dependencies were removed. The effect now derives defaults from agent and input.effectiveRuntime inside the effect. This avoids the prior redundant dependency issue. The current-head react-doctor check is successful.

The cited Preflight (codegen, installer, product language) job passed for 551116428139e543609ed4c843e6f355ee9cc327. It completed generated-artifact verification successfully. The overall CI workflow failed in a separate Go race-test shard, so the successful Preflight job is valid code-generation evidence but not evidence of an all-green workflow.

The added comments describe the changed ownership, discovery, persistence, and synchronization behavior. The documentation warning does not require another code change from this review. I cannot confirm a coverage threshold from the supplied evidence. The current-head CI coverage remains in progress.

Learnt from: pedronauck
URL: https://github.com/compozy/compozy/pull/658

Timestamp: 2026-09-16T19:31:32.280Z
Learning: In the Go model catalog, `ModelSourceRow.ConfigOptions` and `ModelTransportBinding.ConfigOptions` have separate domains. Row-level `ConfigOptions` define logical configuration-matrix coordinates, and `ModelSourceTransportBinding.OptionSelections` selects a transport through those coordinates. Binding-level `ConfigOptions` is a complete ACP control snapshot observed after transport selection. SQLite validation and foreign keys must apply `OptionSelections` to row-level matrix options, not to binding-level ACP control snapshots.

You are interacting with an AI system.

#!/bin/bash
set -euo pipefail

base="551116428139e543609ed4c843e6f355ee9cc327"
head="9f8c20f142353b492944b1c277e470ce4a55db80"

printf '%s\n' '=== Commit range and changed files ==='
git diff --stat "$base..$head"
git diff --name-status "$base..$head"

printf '%s\n' '=== Commit availability and target ancestry ==='
git rev-parse HEAD
git merge-base --is-ancestor "$base" "$head" && echo "base is ancestor of head"
git show -s --format='%H%n%s%n%ci' "$head"

printf '%s\n' '=== Relevant source outlines ==='
ast-grep outline internal/modelcatalog/reasoning_merge.go --items all
ast-grep outline internal/modelcatalog/bindings.go --items all
ast-grep outline internal/modelcatalog/options.go --items all
ast-grep outline internal/store/globaldb/global_db_model_catalog_options.go --items all
ast-grep outline internal/store/globaldb/global_db_model_catalog_bindings.go --items all
ast-grep outline web/src/systems/session/hooks/use-session-prompt-runtime.ts --items all

printf '%s\n' '=== Relevant remediation diff ==='
git diff --unified=80 "$base..$head" -- \
  internal/modelcatalog/reasoning_merge.go \
  internal/modelcatalog/bindings.go \
  internal/modelcatalog/options.go \
  internal/modelcatalog/service_test.go \
  internal/store/globaldb/global_db_model_catalog_options.go \
  internal/store/globaldb/global_db_model_catalog_bindings.go \
  internal/store/globaldb/global_db_model_catalog_test.go \
  web/src/systems/session/hooks/use-session-prompt-runtime.ts \
  web/src/systems/session/hooks/__tests__/use-session-prompt-runtime.test.tsx \
  internal/extension/contract/model_source.go \
  internal/extension/model_source_options.go

printf '%s\n' '=== Referenced disposition comment ==='
gh api repos/compozy/compozy/issues/comments/5702870783 --jq '.user.login, .created_at, .body'

printf '%s\n' '=== Current PR state ==='
gh pr view 658 --repo compozy/compozy --json headRefOid,statusCheckRollup,reviews --jq '{headRefOid, checks: [.statusCheckRollup[] | {name, status, conclusion}], reviews: [.reviews[] | {author: .author.login, state, submittedAt}]}'

#!/bin/bash
set -euo pipefail

base="551116428139e543609ed4c843e6f355ee9cc327"
head="9f8c20f142353b492944b1c277e470ce4a55db80"

printf '%s\n' '=== All changed production diffs ==='
git diff --unified=50 "$base..$head" -- \
  internal/acp/config_options.go \
  internal/acp/session_config_negotiation.go \
  internal/modelcatalog/claude_model_rows.go \
  internal/modelcatalog/live_sources_acp.go \
  internal/session/manager_start_test.go \
  internal/session/provider_runtime_test.go \
  web/src/systems/runtime/components/runtime-selector/runtime-advanced-options-model.ts \
  web/src/systems/session/contexts/session-prompt-runtime-context.tsx \
  web/src/systems/session/hooks/use-session-prompt-runtime.ts

printf '%s\n' '=== Full current reasoning merge and ACP construction ==='
sed -n '1,210p' internal/modelcatalog/reasoning_merge.go
sed -n '1,360p' internal/modelcatalog/live_sources_acp.go
sed -n '1,140p' internal/modelcatalog/option_merge.go
sed -n '1,160p' internal/modelcatalog/bindings.go

printf '%s\n' '=== External store default event semantics ==='
fd -a 'session-prompt-runtime-store*' web/src/systems/session
rg -n -A90 -B30 '\bdefaultRuntimeResolved\b|defaultValue|defaultSpeed' web/src/systems/session

printf '%s\n' '=== Tests that cover changed ACP and catalog behavior ==='
rg -n -A140 -B25 '\b(TestInspectSessionModels|TestConfigureRuntime|applySessionConfigOption|InspectSessionModels|empty binding|absent reasoning policy)\b' \
  internal/acp/client_start_contract_test.go \
  internal/acp/client_test_support_test.go \
  internal/modelcatalog/live_sources_test.go \
  internal/modelcatalog/service_integration_test.go \
  internal/modelcatalog/service_test.go

printf '%s\n' '=== Documentation commit changes ==='
git diff --unified=12 'fac7fe19d..9f8c20f142353b492944b1c277e470ce4a55db80' -- docs internal web
printf '%s\n' '=== Added/changed production function comments in range ==='
git diff --unified=2 "$base..$head" -- internal web | rg -n -C3 '^\+(\s*//|/\*\*|\s*\*|\s*(export )?func |.*\bfunction\b)' || true

@pedronauck Completed the remediation review for 9f8c20f142353b492944b1c277e470ce4a55db80. I found no new blocking issue in the requested scope.

• Empty snapshots: nil remains “unobserved.” An empty non-nil ConfigOptions slice remains “observed with no adjustable options.” The clone, normalization, SQLite JSON round-trip, and merge paths preserve this distinction. An observed empty preferred binding clears lower-priority effort metadata.
• Absent policy: applyEffectiveReasoningProfile now distinguishes an absent MergeOptions.ReasoningApply entry from an explicit false entry. Only explicit false produces reasoning_apply: "none" and marks provider-managed capability as known.
• Hook simplification: The useSessionPromptRuntime effect remains necessary. It updates SessionPromptRuntimeStore, and getSessionPromptRuntimeSnapshot reads that store outside React rendering. The effect now derives defaults from agent and input.effectiveRuntime inside the effect. This removes the redundant derived-object dependencies.
• Documentation: The changed function comments describe ownership and behavior. The QA documents correctly mark provider acknowledgement, queued prompts, and recovery as blocked verification. They do not claim completion.

I also explicitly confirm both prior dispositions:

1. Binding-selection validation: Withdrawn. ModelSourceRow.ConfigOptions and ModelTransportBinding.ConfigOptions have separate domains. OptionSelections must validate against row-level matrix coordinates. Binding-level ConfigOptions is the inspected ACP control snapshot after transport selection. I used the previously clarified contract distinction for this assessment.
2. Default-runtime effect: Withdrawn. The synchronization is for the external prompt-runtime store. Removing it would permit stale imperative snapshots.

react-doctor and the code-generation preflight are successful at the reviewed head. Other CI jobs remain in progress. The real-provider QA blocker remains valid and is not treated as delivery-complete evidence.

Learnt from: pedronauck
URL: https://github.com/compozy/compozy/pull/658

Timestamp: 2026-09-16T19:31:32.486Z
Learning: In the Go model catalog, `ModelSourceRow.ConfigOptions` and `ModelTransportBinding.ConfigOptions` have separate domains. Row-level `ConfigOptions` define logical configuration-matrix coordinates, and `ModelSourceTransportBinding.OptionSelections` selects a transport through those coordinates. Binding-level `ConfigOptions` is a complete ACP control snapshot observed after transport selection. SQLite validation and foreign keys must apply `OptionSelections` to row-level matrix options, not to binding-level ACP control snapshots.

Review disposition for de400956b6748dc20a99e379aa1f824afb2ba702:

• CodeRabbit completed the incremental review and approved this head (review 5227551749). Per-binding profiles, explicit capability provenance, empty-catalog hydration, observed-empty persistence, absent apply policy, and test naming findings are fixed with canonical regression coverage. All CodeRabbit inline threads are resolved. Function documentation coverage is now 80.49%, passing the configured 80% threshold.
• CodeRabbit explicitly withdrew the configuration-matrix validation suggestion after confirming that logical option coordinates and post-selection ACP snapshots have distinct contracts; existing SQLite foreign keys remain intact. It also confirmed the corrected external-store effect and withdrew the proposal to keep stale effort levels when a complete ACP snapshot removes the thought-level option.
• Greptile reviewed this head (53 files, zero new comments). Its existing application QA finding is accepted and unresolved. CodeRabbit's linked-issue warning points to the same outstanding acceptance evidence.
• React Doctor passed this head with zero annotations/new issues. The previous hook complexity finding is fixed.

The remaining real-provider gap is not waived: the isolated application must successfully submit Fable 5.1 with the selected effort, confirm effective configuration, and exercise queued prompts/recovery with the final binary. A minimal official-adapter control independently confirmed the account Fable usage limit; the latest application retry also encountered native authentication resolution failure. The inspected rendered selector, persistence, model-switch and narrow-viewport evidence do not substitute for that final walk.

The isolated lab has been cleanly stopped and its evidence retained. No operator session or host daemon was restarted. This PR remains open and must not be delivered or merged as complete until the real-provider acceptance gap is closed.