Repository navigation
YSH-98: Remove default scope in delete interceptor - #111
Merged
ShannonAmandaAmarasekara merged 6 commits intoJul 4, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
strokyl
approved these changes
Jul 3, 2025
marnas
approved these changes
Jul 3, 2025
caoilte-conduktor
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gateway delete interceptor endpoint is being updated to receive the interceptor scope as optional. This PR is to update the logic of handling delete interceptor requests using the cli, to not set a default scope when no scope is provided.
Scenario:
Given a user has deployed an interceptor with no scope using the cli
When the user deletes this interceptor with no scope using the cli
Then the delete should succeed
Releasing (cli first or gateway?):
old cli + new gateway -> "Could not delete resource Interceptor/inject-header: Interceptor inject-header not found with scope {vCluster=null, group=null, username=null}"
new cli + old gateway -> Could not delete resource Interceptor/inject-header: Invalid value for: body (exhausted input)
See the PR on the gateway:
https://github.com/conduktor/conduktor-proxy/pull/2581
Linear ticket:
https://linear.app/conduktor/issue/YSH-98/delete-interceptors-vcluster-null-inconsistency-with-put
Example with screenshots:
