Repository navigation
Conversation
qboileau
approved these changes
Jul 17, 2024
qboileau
left a comment
Member
There was a problem hiding this comment.
LGTM
@twobeeb BTW why we never went with the de-facto yaml standard !include 'xx.txt'.
Not in real yaml spec but implemented in some parsers and many people are familiar with it
Contributor
Author
Quentin did you check if it work with the go parser? |
strokyl
deleted the
cons-1378-cli-add-support-for-descriptionfile-in-topic-resource
branch
July 17, 2024 08:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On this PR, I added the possibility of using a separate file for the description of a topic resource.
For example, now the user can apply the following
yaml:If
tata_desc.mdcontain the following content:This would be the equivalent of applying the following resource:
I took the opportunity to improve error handling of the similar existing mechanism for subject schema.