Repository navigation
fix: Bump MSRV to 1.96.0 and fix release-binary paths - #326
Merged
Merged
Conversation
c2pa-rs's breaking train (0.91.0) raised its own rust-version to 1.96.0. Match it here: bump Cargo.toml's rust-version, the Tier-1A MSRV matrix leg, and the WASI/rustfmt nightly pins (nightly-2026-01-16 reports rustc 1.94.0-nightly, below the new floor; nightly-2026-07-12 matches what c2pa-rs itself already uses and reports 1.99.0-nightly). Also refreshes Cargo.lock (`cargo update -p c2pa` then `-p rustls`), which incidentally fixes a real advisory: the previously-locked rustls 0.23.44 trips a TLS 1.3 handshake-boundary vulnerability that 0.23.45 (already used by c2pa-rs) does not. Co-Authored-By: Claude Sonnet 5 <[email protected]>
c2patool-release.yml still did `cd cli && make release` / `cd cli && cargo sbom`, and the Makefile's release targets all referenced `../target`, both leftover from when this crate lived in a `cli/` subdirectory. It now lives at the repo root, so `cd cli` no longer exists (it was silently failing every step after it) and `../target` would resolve outside the repo entirely once that `cd` is removed. Drop the `cd cli` prefix and point the Makefile at `target` directly. This is c2patool's first tag-triggered release build, so this bug had never actually been exercised until now. Co-Authored-By: Claude Sonnet 5 <[email protected]>
scouten-adobe
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage 72.16% 72.16%
=======================================
Files 4 4
Lines 1060 1060
=======================================
Hits 765 765
Misses 295 295 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first real train cut for this repo (
0.28.0-rc, tracking c2pa-rs's0.91.0-rc) surfaced three separate, previously-latent problems — none caused by the cut itself, just never exercised before:rust-versionto1.96.0. This bumpsCargo.toml'srust-version, the Tier 1A MSRV matrix leg (1.88.0→1.96.0),docs/support-tiers.md, and the WASI/rustfmt nightly pins (nightly-2026-01-16reportsrustc 1.94.0-nightly, below the new floor; switched tonightly-2026-07-12, which c2pa-rs's own CI already uses and reports1.99.0-nightly).c2padependency (cargo update -p c2pa, then-p rustls) picks uprustls 0.23.45, fixing a real advisory (TLS 1.3 handshake messages accepted across encryption-level boundaries) that the previously-locked0.23.44was exposed to. c2pa-rs itself already pins0.23.45.c2patool-release.ymlstill didcd cli && make release/cd cli && cargo sbom, and the Makefile's release targets referenced../target— both leftover from when this crate lived in acli/subdirectory. It's been at the repo root for a while, socd cliwas failing immediately, and simply removing it would have pointed../targetoutside the repo entirely. Fixed both together: droppedcd cli, repointed the Makefile attargetdirectly. Verified locally (make build-release-mac-armproduces the binary at the expected path).Verified locally:
cargo check --all-features,cargo test --all-features,cargo +nightly-2026-07-12 fmt --all -- --check, andcargo deny check(advisories/bans/licenses/sources all green) all pass.Test plan
0.28.0-rcfrommainafter this merges and confirm Tier 1A and the binary-release build are green🤖 Generated with Claude Code