Repository navigation
test: Skip atomic write replacement test on WASI - #343
Merged
Merged
Conversation
std::process::id() is unsupported on WASI, and tempfile's tempdirectory cleanup path uses it when removing the directory. The test exercises native atomic replacement behavior, so keep it on native targets only. Co-authored-by: Copilot App <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage 72.32% 72.32%
=======================================
Files 4 4
Lines 1066 1066
=======================================
Hits 771 771
Misses 295 295 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scouten-adobe
added
the
backport-stable
Collaborator
|
Backport-action failed to backport this pull request in workflow run 35739403152.
❌ stable — unable to cherry-pickTried to cherry-pick commits onto Please cherry-pick the changes locally and resolve any conflicts: git fetch origin stable
git worktree add -d .worktree/backport-343-to-stable origin/stable
cd .worktree/backport-343-to-stable
git switch --create backport-343-to-stable
git cherry-pick -x 67ba94e0c880a1b13df4c2cff6774f8295a6bd61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atomic_write_file_writes_and_replaceson WASI, where the tempdirectory cleanup path reaches unsupportedstd::process::id().Validation
cargo testCARGO_TARGET_WASM32_WASIP2_RUNNER="wasmtime -S cli -S http --dir . --env GITHUB_ACTIONS=${GITHUB_ACTIONS}" CC=clang RUST_MIN_STACK=16777216 cargo +nightly-2026-07-12 test --target wasm32-wasip2 -- --no-capture