Repository navigation
only walk statement nodes when scanning for defs and classes - #2216
Merged
Merged
Conversation
_raw_parse and AstArcAnalyzer.analyze used ast.walk to find module, function, and class nodes, visiting every node in the tree. Those are all statements, which can never appear inside expression subtrees. We can optimize this with walk_statement_nodes, which is ast.walk with the enqueue filtereds. This also replace analyze()'s per-node getattr dispatch with isinstance checks against the three handler types.
Member
|
This is now released as part of coverage 7.15.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_raw_parseandAstArcAnalyzer.analyzeuseast.walkto find module, function, and class nodes, visiting every node in the tree. Those are all statements, which can never appear inside expression subtrees.We can optimize by adding
walk_statement_nodeswhich filters out statements.This also replace analyze()'s per-node getattr dispatch with isinstance checks against the three handler types.
Some performance tests as run by claude (4 core x86_64 VM):
~0.4s saved (with some variance due to standard benchmarking challenges).