Skip to content

Commit 8b19d24

Browse files
scooby87scooby87
committed
fix(keda): use the KEDA 2.20 metric name in the scaler-errors alert
The DatabaseAutoscalerScalerErrors rule queried keda_scaler_errors_total, which KEDA 2.20 no longer exposes (verified against a live 2.20.2 operator: it emits keda_scaled_object_errors_total for per-ScaledObject errors and keda_scaler_detail_errors_total for per-scaler errors). The alert would have silently never fired. Switch to keda_scaled_object_errors_total and add a unittest assertion pinning the metric name so a rename regresses loudly. Addresses CodeRabbit review feedback on #3954. Signed-off-by: Alexey Artamonov <[email protected]>
1 parent 279ce52 commit 8b19d24

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

‎packages/system/keda/templates/alerts.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ spec:
4646
# scaling silently stops. Never scale blind.
4747
- alert: DatabaseAutoscalerScalerErrors
4848
expr: |-
49-
increase(keda_scaler_errors_total[15m]) > 0
49+
increase(keda_scaled_object_errors_total[15m]) > 0
5050
for: 15m
5151
labels:
5252
severity: warning

‎packages/system/keda/tests/db_autoscaling_alerts_test.yaml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,13 @@ tests:
3232
content:
3333
alert: DatabaseAutoscalerScalerErrors
3434
any: true
35+
# Guard the metric name: KEDA 2.20 renamed keda_scaler_errors_total away;
36+
# the per-ScaledObject error counter is keda_scaled_object_errors_total
37+
# (verified on a live 2.20.2 operator). A regression here makes the alert
38+
# silently never fire.
39+
- matchRegex:
40+
path: spec.groups[0].rules[2].expr
41+
pattern: keda_scaled_object_errors_total
3542

3643
- it: can be disabled
3744
set:

0 commit comments

Comments
 (0)