Skip to content

No CI coverage for the isp-hosted platform variant #3390

Closed

Description

@myasnikovdaniil

Symptom

The isp-hosted platform variant is not exercised by anything in CI. rg -rn "isp-hosted" .github/ hack/ returns no matches, and hack/e2e-install-cozystack.bats pins variant: isp-full.

The consequence is visible in #3376: the preset shipped unable to converge from the day it was introduced (2d022e38e, January 2026) and nothing caught it. Reviewing the fix for that issue surfaced further hosted-unaware defaults that had been masked for the same reason, because the preset's system bundle was disabled and so most of its packages were never installed by anyone.

What is missing

There is no live-cluster verification that the hosted topology works — only chart-render assertions. Render-level tests can prove the dependency graph closes; they cannot catch a chart that renders fine and then fails against a cluster lacking Cilium CRDs or a replicated StorageClass, which is exactly what the two accompanying issues describe.

Suggested fix

Add an install lane that exercises isp-hosted against a cluster without LINSTOR and without Cilium, since those absences are what the variant is defined by. It does not need the full app matrix — reaching a converged cozystack-platform HelmRelease with tenant-root Ready would have caught every problem found here.

The lightweight container-based lane is a plausible host for this: isp-hosted needs neither KVM nor DRBD, which is what makes the full e2e lane expensive.

If a live lane is not affordable, a cheaper backstop is a render-time dependency-closure check over every registered variant, which would at least have caught #3376 itself. See the accompanying disabledPackages issue for that proposal.

Notes

Found while reviewing the fix for #3376.

Activity

  1. added
    kind/failing-testCategorizes issue or PR as related to a consistently or frequently failing test
    priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release
    area/ciIssues or PRs related to CI workflows, GitHub Actions, automation
    area/testingIssues or PRs related to testing (e2e, bats, unit tests)
    on Jul 21, 2026
  2. added
    kind/featureCategorizes issue or PR as related to a new feature
    and removed
    kind/failing-testCategorizes issue or PR as related to a consistently or frequently failing test
    on Sep 23, 2026
  3. added a commit that references this issue on Oct 5, 2026
    7ea7104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area/ciIssues or PRs related to CI workflows, GitHub Actions, automationarea/testingIssues or PRs related to testing (e2e, bats, unit tests)kind/featureCategorizes issue or PR as related to a new featurepriority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next releasetriage/acceptedIndicates an issue is ready to be actively worked on

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions