Skip to content

ci: editing a disabled chainsaw suite escalates test selection to the full e2e run #3655

Closed

Description

Summary

Editing hack/e2e-chainsaw/backup/chainsaw-test.yaml.disabled escalates test selection to the full e2e run. The selector's suite-mapping step derives the suite name from the path without regard to the .disabled suffix, so the change selects the backup suite; the final intersection against suites that actually exist comes up empty, and the empty-selection safety net fires, which means the full run. Measured on the fail-safe selection branch currently in flight.

Why it matters

A disabled suite is the one file class whose edits provably cannot affect any running test, and it currently buys the most expensive outcome the selector has. The practical annoyance is small (edits to disabled suites are rare), but the mapping is exactly backwards, and anyone re-enabling or grooming the disabled suite pays a full run per commit while doing it.

Fix shape

Teach the suite-mapping step to recognize *.disabled and classify such paths as inert with a comment stating why (a disabled suite runs nowhere, so nothing can regress), or map it to the suite it would become and let the intersection drop it silently without triggering the safety net. Either way the safety net keeps its job for paths that are genuinely unclassified.

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug
    area/ciIssues or PRs related to CI workflows, GitHub Actions, automation
    on Aug 8, 2026
  2. lexfrei commented on Sep 23, 2026

    @lexfrei
    ContributorAuthor

    Fixed by #3670. hack/select-e2e.sh treats hack/e2e-chainsaw/*/*.disabled as inert, so editing a disabled suite selects nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/ciIssues or PRs related to CI workflows, GitHub Actions, automationkind/bugCategorizes issue or PR as related to a bugtriage/not-reproducibleIndicates an issue can not be reproduced as described

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions