Skip to content

ci: select-e2e maps only *-application sources, so kuberture and securitygroup suites are never selected by dependency #3665

Description

Summary

The source-to-suite mapping in hack/select-e2e.sh (the case around lines 245-251 on current main) only maps sources whose name ends in -application, plus a hardcoded external-dns. Two suites stand on sources that match neither: kuberture (cozystack.kuberture) and securitygroup (cozystack.securitygroup-controller). The dependency-graph walk reaches both of them (each declares dependsOn: cozystack.networking), but the final filter discards them because their source name is not *-application.

Why it matters

packages/core/platform/sources/networking.yaml owns system/cilium, so an edit to packages/system/cilium/values.yaml selects 19 of the 21 suites, everything except kuberture and securitygroup. Those two are exactly the controllers that depend on the CNI being changed, so a CNI change does not run the suites most likely to regress from it. Symmetrically, an edit to packages/system/kuberture/* maps to no suite, falls through to the empty-selection safety net, and burns the full run instead of its own suite. The old wc -w > 5 full-suite assertions in select-e2e_test.bats hid this, since 19 is still greater than 5; converting them to exact-set equality surfaces it as the one failing case of 27, with the other 26 staying green.

Fix shape

Either add kuberture and securitygroup-controller next to the existing external-dns exception, or generalize the filter to map any source whose derived suite name exists in the known suite set (all_apps) rather than gating on the -application suffix. The general form is preferable: it also covers future non-application suites instead of accumulating hardcoded names.

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug
    area/ciIssues or PRs related to CI workflows, GitHub Actions, automation
    on Aug 8, 2026
  2. added a commit that references this issue on Aug 10, 2026
    6ee56e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/ciIssues or PRs related to CI workflows, GitHub Actions, automationkind/bugCategorizes issue or PR as related to a bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions