You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: select-e2e escalates packages/tests edits by fall-through, printing a false 'unclassified path' call-to-action #3667
An edit under packages/tests/** is not classified by hack/select-e2e.sh: it matches no rule, falls through to the step-6 escalation, runs the full suite, and prints select-e2e: unclassified path '<file>' — escalating to the full suite (classify it in hack/select-e2e.sh, see #3392). The full_suite_pattern (line 75) lists packages/library/, packages/core/, and others, but not packages/tests/.
Why it matters
The escalation itself is correct: packages/tests/cozy-lib-tests exercises packages/library/cozy-lib, which is already in full_suite_pattern, so a change there should run everything. The problem is that the correct outcome is reached by fall-through rather than by a rule, so it emits a call-to-action ("classify it") that implies the path was forgotten. As packages/tests/ becomes a first-class location for unit tests (the helm-unit sweep now visits it), that misleading line will fire on every edit to those tests, training readers to ignore a message that is supposed to mean "a genuinely unclassified path slipped through".
Fix shape
Add packages/tests/ to full_suite_pattern so the escalation is a stated decision, not a remnant. One entry, no behavior change to what runs (the full suite runs either way); it only moves the path from the fall-through branch to an explicit rule and silences the false call-to-action.
Fixed in #3817. packages/tests/ now has an explicit rule, so the unclassified-path message is gone. The rule makes it inert rather than full-suite: a change to a cozy-lib test doesn't change cozy-lib, and changes to the library itself still escalate through packages/library/.
Activity
fix(ci): close the silent-green gaps in e2e selection and the helm un…
lexfrei commentedon Sep 23, 2026
Fixed in #3817.
packages/tests/now has an explicit rule, so the unclassified-path message is gone. The rule makes it inert rather than full-suite: a change to a cozy-lib test doesn't change cozy-lib, and changes to the library itself still escalate throughpackages/library/.