Skip to content

Monitoring OIDC mode swap from inline to secretRef has no test coverage #3785

Closed

Description

@myasnikovdaniil

Nothing covers a running monitoring release changing spec.oidc from customConfig inline config to secretRef. Both end states are pinned in packages/system/monitoring/tests/oidc_test.yaml, the transition between them is not.

This is the one open item from the ledger in #3778, which deleted hack/e2e-apps/monitoring-oidc-customconfig.bats. That file had a test doing the swap in place on a live release, and it never ran because no runner invoked that directory, so it was not real coverage either. It was the only thing pointing at the gap.

What it would catch happens at upgrade time and not at render time, inner HR keeping the previous auth.generic_oauth config while the new volume mount arrives, or the old -oidc-client Secret left behind after the mode no longer needs it. Render tests cannot see any of that.

Cost is why I did not add it in #3778. The swap needs the inner release to converge first and flux serialises operations on one HR with timeout: 15m, so a chainsaw suite doing this is around 10 to 15 minutes on every full e2e run. Worth deciding if that is the right price before someone writes it.

Activity

  1. added
    kind/featureCategorizes issue or PR as related to a new feature
    area/testingIssues or PRs related to testing (e2e, bats, unit tests)
    area/monitoringIssues or PRs related to the monitoring stack (vlogs, vmstack, grafana, workloadmonitor)
    on Aug 12, 2026
  2. added
    triage/acceptedIndicates an issue is ready to be actively worked on
    priority/backlogGeneral backlog priority. Lower than priority/important-longterm
    and removed
    triage/needs-triageIndicates an issue needs triage by a maintainer
    on Sep 23, 2026
  3. added a commit that references this issue on Oct 5, 2026
    858ca4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area/monitoringIssues or PRs related to the monitoring stack (vlogs, vmstack, grafana, workloadmonitor)area/testingIssues or PRs related to testing (e2e, bats, unit tests)kind/featureCategorizes issue or PR as related to a new featurepriority/backlogGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked on

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions