Skip to content

select-e2e: the unit-lane bats count in the comment and the doc is wrong, and should be removed rather than fixed #4120

Description

hack/select-e2e.sh and docs/agents/e2e-testing.md both explain the unit/e2e bats split by quoting a count: BATS_UNIT_FILES "keeps 60 files". Counted on current main, hack/*.bats is 94 files with three hack/e2e-*.bats among them, so the filter keeps 91.

The number appears twice in each file, first as "the 60 files it keeps" and again as "those 60 files" in the script and "never executes one of the 60" in the doc. Four sites.

Correcting it to 91 buys about one pull request. The count was accurate when it was written, nothing checks it, and it goes stale the next time anyone adds a bats file under hack/. Both places quote BATS_UNIT_FILES := $(filter-out hack/e2e-%.bats,$(wildcard hack/*.bats)) directly next to the claim, and that expression is what defines the set; the cardinality on any particular day adds nothing a reader needs.

Dropping the number from all four sites leaves both explanations intact and removes the only part of them that can rot.

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug
    area/ciIssues or PRs related to CI workflows, GitHub Actions, automation
    on Sep 7, 2026
  2. added
    triage/acceptedIndicates an issue is ready to be actively worked on
    priority/backlogGeneral backlog priority. Lower than priority/important-longterm
    and removed
    triage/needs-triageIndicates an issue needs triage by a maintainer
    on Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area/ciIssues or PRs related to CI workflows, GitHub Actions, automationkind/bugCategorizes issue or PR as related to a bugpriority/backlogGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked on

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions