rest.go names two carriers of helm-install-timeout while four RDs set it #4147

pkg/registry/apps/application/rest.go explains the timeout annotations and then names who uses them: "kubernetes-rd and tenant-rd carry helm-install-timeout today", with a paragraph of justification for each and a closing "any future kind with the same shape can opt in by setting the same annotation".

Grepping the RD tree gives four carriers, not two: kubernetes-rd, kubernetes-nodes-rd, monitoring-rd and tenant-rd. The comment was already wrong before the change I am filing this from, and that change adds vm-disk-rd as a fifth, so it gets wronger.

The interesting part is that the closing sentence makes the list pointless. Once the comment says any kind can opt in, naming today's carriers adds nothing a reader can act on: they cannot rely on the list being complete, and if they want to know who sets it they run the grep that produced the four above. What the list does instead is decay, silently, every time a kind opts in, exactly as it has.

So the fix is probably deletion rather than correction. Keep the two paragraphs explaining what the annotations do and why a kind would want an asymmetric budget, drop the enumeration of who currently does, and let the closing sentence carry the rule it already states.

If the enumeration is wanted for a reason I am not seeing, then it needs something that fails when it drifts, because a comment listing files is a claim about a set and nothing in the tree checks it.