Skip to content

Patched first-party images run go build only, so tests carried in a patch never run #4318

Closed

Description

Fifteen Dockerfiles under packages/ today apply patches to an upstream source tree and then run go build, packages/system/opensearch-operator/images/opensearch-operator/Dockerfile among them. Nothing in the repository runs go test on the patched tree: a _test.go carried inside a patch does not break go build, and no CI job compiles or runs it.

#4317 carries the upstream tests for the operator's restart gate inside restart-on-permanently-yellow.diff. They were green when the patch was cut, by hand, in a scratch tree. After the next ARG VERSION bump nothing notices if they stop compiling or start failing. The same holds for every other patched image; the older bootstrap-voting-exclusion.diff carries no tests at all, so there the gap is one step earlier.

Two places this could live: a RUN go test on the packages the patches touch, in the builder stage before the final build, or a unit-lane check that applies the patches to the pinned tarball and runs the tests there. Which one, and whether the build-time cost is acceptable for all fifteen images, is a maintainer call, so I am filing this rather than opening a PR.

Activity

  1. added
    kind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debt
    area/buildIssues or PRs related to image build infrastructure, multi-arch support
    area/testingIssues or PRs related to testing (e2e, bats, unit tests)
    triage/acceptedIndicates an issue is ready to be actively worked on
    priority/backlogGeneral backlog priority. Lower than priority/important-longterm
    and removed
    triage/needs-triageIndicates an issue needs triage by a maintainer
    on Sep 23, 2026
  2. added a commit that references this issue on Oct 3, 2026
    091b854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/buildIssues or PRs related to image build infrastructure, multi-arch supportarea/testingIssues or PRs related to testing (e2e, bats, unit tests)kind/cleanupCategorizes issue or PR as related to cleanup of code, process, or technical debtpriority/backlogGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions