Skip to content

Timeout override comments call a per-kind setting per-Application #4382

Closed

Description

The comments around the helm install and upgrade timeout overrides call them per-Application, but the value is set once per kind. cozystack-api reads release.cozystack.io/helm-install-timeout and release.cozystack.io/helm-upgrade-timeout from the kind's ApplicationDefinition (pkg/cmd/server/start.go:305-316) and uses the same value for every Application of that kind. The annotations of an Application itself are not read for this, so someone who takes "per-Application" literally sets the annotation on one Application and nothing changes.

Places on origin/main at a759190:

  • pkg/registry/apps/application/rest.go:1612, "Per-Application annotation overrides win over the global defaults"
  • pkg/config/config.go:207 and :213, the field docs of HelmInstallTimeout and HelmUpgradeTimeout
  • pkg/config/config.go:232 and :236, the field docs of HelmReleaseInstallTimeout and HelmReleaseUpgradeTimeout
  • pkg/cmd/server/start.go:278-280

There is a second gap in two of them. config.go:236 says HelmReleaseUpgradeTimeout is overridden by HelmInstallTimeout and does not mention HelmUpgradeTimeout, which overrides it too and wins over both (rest.go:1633-1635). start.go:280 names only the install annotation in the same way.

The fix is wording only. Say "per kind" or "from the ApplicationDefinition" where these comments say "per-Application", and name both annotations where only one is named.

Activity

  1. added
    kind/documentationCategorizes issue or PR as related to documentation
    area/apiIssues or PRs related to the cozystack-api aggregated API server
    triage/acceptedIndicates an issue is ready to be actively worked on
    priority/backlogGeneral backlog priority. Lower than priority/important-longterm
    and removed
    triage/needs-triageIndicates an issue needs triage by a maintainer
    on Sep 23, 2026
  2. added a commit that references this issue on Sep 27, 2026
    9c7fbe8
  3. added a commit that references this issue on Oct 10, 2026
    9b35fa0
  4. added a commit that references this issue on Oct 10, 2026
    bd8264f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/apiIssues or PRs related to the cozystack-api aggregated API serverkind/documentationCategorizes issue or PR as related to documentationpriority/backlogGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions