Skip to content

test: the cross-compile check never looks at the multus build stage #4500

Closed

Description

The cross-compile check added in #4498 skips the multus build stage completely. hack/image-builders-cross-compile.bats treats a Dockerfile stage as compiling when a RUN command is go build/test/install, make, gradle, a node package manager, or a script matching *build.sh. The multus-cni builder runs upstream ./hack/build-go.sh. That name does not match [^[:space:]]*build[.]sh, so the stage counts as not compiling and nothing checks it.

Multus itself builds correctly today. Its builder is on $BUILDPLATFORM, and upstream build-go.sh takes the target from TARGETPLATFORM. The problem is only that the check says it covers this stage and it does not.

Changing the pattern to [^[:space:]]*build[^[:space:]/]*[.]sh would pull the stage in. It would then pass because of the TARGETARCH in the curl step of the same stage. That is the per-stage limit the test header already names: the check looks at the whole stage, not at the line that compiles.

Activity

  1. added a commit that references this issue on Oct 1, 2026
    d8ec8f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

triage/needs-triageIndicates an issue needs triage by a maintainer

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions