Skip to content

build(talos): image-talos pushes even with PUSH=0 #4551

Closed

Description

The Talos installer target publishes its image even when pushing is switched off. Every other image target gets the switch through BUILDX_ARGS (--push=$(PUSH)), so PUSH=0 means a local build with nothing published. image-talos in packages/core/talos/Makefile builds with the imager and then pushes with skopeo copy ... docker://$(REGISTRY)/talos:..., and nothing in that recipe reads PUSH.

The only way to skip the push today is OCI_EXPORT_DIR, which writes an OCI archive instead. A local make image PUSH=0 still publishes a talos tag to whatever REGISTRY points at. That is surprising, and it can overwrite a tag someone else relies on.

I'd like the skopeo copy docker:// lines to run only when PUSH=1, the same contract the buildx targets have.

Activity

  1. added a commit that references this issue on Oct 5, 2026
    2ddd55c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

triage/needs-triageIndicates an issue needs triage by a maintainer

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions