Repository navigation
docs(computeplane): the module passes more per-pool fields than its docs list #4716
Description
The computeplane module docs say it passes "only the documented per-pool fields" to kubernetes-nodes. The pick allowlist in packages/extra/computeplane/templates/cluster.yaml passes eight more fields than the module's schema lists (for example kubelet, logSerialConsole, podCpuLimit), and the computeplane e2e suite (#4713) relies on three of them. Fix shape: list every allowlisted field in the module's values schema and docs, and add a unit check that the allowlist and the schema's pool fields stay equal, so a field cannot be passed without being documented or documented without being passed.
Activity
lexfrei commentedon Oct 2, 2026
One more field for the same check:
kernelModules(added to the pool chart in f7c04b7) is not in thepicklist inpackages/extra/computeplane/templates/cluster.yaml, so the module drops it. A GPU pool still gets the chart's automatic NVIDIA set, because that keys ongpus, which is passed. A tenant can't replace the list or opt out with[].Leaving it out may be on purpose, since the module runs tenant input and the list ends up in the Talos machine config. If so, the allowlist/schema check should carry that exclusion explicitly, so it reads as a decision and not a gap.
test(e2e): cover the computeplane module end to end (#4713)