Repository navigation
Add schema generation and remove default values - #110
Merged
Merged
Conversation
Andrei Kvapil (kvaps)
commented
Apr 26, 2024
Andrei Kvapil (kvaps)
commented
Member
- Remove any possible default users and settings and move them to examples
- Use readme-generator-for-helm for generate openapi schema
Andrei Kvapil (kvaps)
force-pushed
the
openapi-schema-generation
branch
2 times, most recently
from
April 26, 2024 13:22
5522e23 to
be9b3ad
Compare
Marian Koreniuk (themoriarti)
self-requested a review
April 26, 2024 13:29
| @@ -0,0 +1,36 @@ | |||
| --- | |||
| apiVersion: kamaji.clastix.io/v1alpha1 | |||
Collaborator
There was a problem hiding this comment.
I'm not sure here, can you clarify?
Member
Author
There was a problem hiding this comment.
This file is from another pull request #95 and will be updated to this version once the first one is merged
Signed-off-by: Andrei Kvapil <[email protected]>
Andrei Kvapil (kvaps)
force-pushed
the
openapi-schema-generation
branch
from
April 26, 2024 14:34
be9b3ad to
f25bbd5
Compare
Marian Koreniuk (themoriarti)
approved these changes
Apr 26, 2024
Marian Koreniuk (themoriarti)
left a comment
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Andrei Kvapil (kvaps)
marked this pull request as ready for review
May 8, 2024 08:31
Marian Koreniuk (themoriarti)
approved these changes
May 8, 2024
Member
Author
|
Yeah we forgot to merge them into v0.4.0, would go to v0.5.0 |
Andrei Kvapil (kvaps)
marked this pull request as draft
May 8, 2024 18:55
Marian Koreniuk (themoriarti)
approved these changes
May 8, 2024
Marian Koreniuk (themoriarti)
left a comment
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good
Andrei Kvapil (kvaps)
marked this pull request as ready for review
May 9, 2024 08:45
This was referenced May 14, 2024
Merged
Merged
Merged
Merged
This was referenced May 21, 2024
Merged
This was referenced May 28, 2024
Merged
Merged
This was referenced Jun 10, 2024
Merged
This was referenced Jun 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.