Repository navigation
Fix: kafka replicas and partitions - #192
Merged
Merged
Conversation
Andrei Kvapil (kvaps)
requested review from
George Gaál (gecube) and
Marian Koreniuk (themoriarti)
July 3, 2024 10:17
Signed-off-by: Andrei Kvapil <[email protected]>
Andrei Kvapil (kvaps)
force-pushed
the
kafka-fix
branch
from
July 3, 2024 12:17
a11f786 to
18a2289
Compare
Marian Koreniuk (themoriarti)
approved these changes
Jul 4, 2024
Marian Koreniuk (themoriarti)
left a comment
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
I haven't tried this feature, but in general it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix kafka app to unhardcode partitions number
fixes problem with unability to specify number of partitions and replicas for them
also possible fixes #163