Repository navigation
fix(e2e): increase HelmRelease readiness timeout for kubernetes test - #2033
Conversation
The 1-minute timeout for waiting on HelmRelease readiness is too short for ingress-nginx after its migration from hostNetwork to NodePort Service, causing consistent E2E failures on kubernetes-latest. Increase the timeout to 5 minutes to allow sufficient time for all components to become ready. Co-Authored-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
📝 WalkthroughWalkthroughThe script's component readiness check logic has been refactored to handle ingress-nginx separately with an extended 5-minute timeout, while moving cilium, coredns, csi, and vsnap-crd into a consolidated batch wait loop. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello Aleksei Sviridkin (@lexfrei), I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a persistent issue with end-to-end tests failing due to an insufficient timeout for HelmRelease readiness. By extending the wait period for critical components like Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the timeout for HelmRelease readiness checks in the E2E test from 1 to 5 minutes, aiming to resolve a consistent failure with the ingress-nginx component. The change is functional and directly addresses the problem. However, I've provided a suggestion to make the timeout increase more specific to ingress-nginx. Applying the longer timeout to all components in the loop could slow down failure detection for other components. A more targeted fix would improve the test suite's efficiency and maintainability.
|
|
||
| for component in cilium coredns csi ingress-nginx vsnap-crd; do | ||
| kubectl wait hr kubernetes-${test_name}-${component} -n tenant-test --timeout=1m --for=condition=ready | ||
| kubectl wait hr kubernetes-${test_name}-${component} -n tenant-test --timeout=5m --for=condition=ready |
There was a problem hiding this comment.
This change increases the timeout for all components in the loop, not just ingress-nginx. While this fixes the immediate issue, it could slow down the feedback loop if another component (like cilium or coredns) fails to become ready, as the test will now wait for 5 minutes instead of 1 before failing for those components. For better precision and faster failure detection on other components, consider applying the longer timeout only to ingress-nginx.
For example, you could handle ingress-nginx outside the main loop, which would involve modifying lines 224-226:
for component in cilium coredns csi vsnap-crd; do
kubectl wait hr kubernetes-${test_name}-${component} -n tenant-test --timeout=1m --for=condition=ready
done
kubectl wait hr kubernetes-${test_name}-ingress-nginx -n tenant-test --timeout=5m --for=condition=readyThere was a problem hiding this comment.
Good point. Applied the targeted fix: 1m timeout stays for cilium/coredns/csi/vsnap-crd, 5m only for ingress-nginx.
dosubot
Bot
added
size/XS
Keep the 1-minute timeout for other components (cilium, coredns, csi, vsnap-crd) to preserve fast failure detection, and apply the 5-minute timeout specifically to ingress-nginx which needs it after the hostNetwork to NodePort migration. Co-Authored-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>
2 participants
Summary
kubectl waittimeout for HelmRelease readiness from 1 minute to 5 minutes in the kubernetes E2E testkubernetes-latestacross multiple PRsTest plan
kubernetes-latestE2E test passes without ingress-nginx timeoutkubernetes-previousE2E test still passesSummary by CodeRabbit