Repository navigation
Fix nginx error related to passthrough TLS - #208
Merged
Merged
Conversation
I don't understand why "true" value isn't accepted here, but I have seen this before. The `--enable-ssl-passthrough` parameter is not supposed to accept any value, it's a stand-alone argument. With this change I get my traffic appropriately passed through to backend ingress on a kubevirt cluster that enabled TLS Without it (on the addon ingress, which is very strange, because that one isn't even configured to use a passthrough annotation...) I get this error: > 400 Bad Request > The plain HTTP request was sent to HTTPS port > --- > nginx Signed-off-by: Kingdon Barrett <[email protected]>
Andrei Kvapil (kvaps)
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't understand why "true" value isn't accepted here, but I have seen this before. The
--enable-ssl-passthroughparameter is not supposed to accept any value, it's a stand-alone argument.With this change I get my traffic appropriately passed through to backend ingress on a kubevirt cluster that enabled TLS
Without it (the change is made on the addon ingress, which is very strange, because that one isn't even configured to use a passthrough annotation... the root ingress controller doesn't seem to care) I get this error: