Repository navigation
Nginx whitelist and clouflareProxy - #211
Conversation
get cloudflare ips and inject to tempalte
Andrei Kvapil (kvaps)
left a comment
Andrei Kvapil (kvaps)
left a comment
There was a problem hiding this comment.
Hi Mr. Khachaturov (@mrkhachaturov) thank you for your contribution! Could you please specify values in values.yaml file
Also, I'd like to change the naming for the options to be more generic, eg:
## @param whitelist List of client networks
## Example:
## whitelist:
## - "1.2.3.4"
## - "10.100.0.0/16"
whitelist: []
## @param realIPProvider Enable configuration for specific RealIP provider. Allowed values: `none` and `cloudflare`
realIPProvider : "none"
|
As about generiting values schema, it can be done using bitnamis readme-generator-for-helm You can check the example here: |
Marian Koreniuk (themoriarti)
left a comment
Marian Koreniuk (themoriarti)
left a comment
There was a problem hiding this comment.
In general, it is an interesting functionality, but it would be good to describe it in a readme.
| @@ -1,2 +1,12 @@ | |||
| get-cloudflare-ips: | |||
| curl -s https://www.cloudflare.com/ips-v4/# | grep -oE '([0-9]{1,3}\.){3}[0-9]{1,3}/[0-9]{1,2}' > ips-v4.tmp | |||
There was a problem hiding this comment.
I would recommend adding a timeout, for example 2-4 seconds, so as not to wait 30 or more seconds if this resource is unavailable for one reason or another.
Andrei Kvapil (kvaps)
changed the title
Andrei Kvapil (kvaps)
left a comment
Andrei Kvapil (kvaps)
left a comment
There was a problem hiding this comment.
Just fixed it a bit. LGTM
Signed-off-by: Andrei Kvapil <[email protected]>
3 participants
Please check Makefile.
I can`t generate new readme.md