Repository navigation
Ship all logos with Cozystack - #218
Conversation
0e5cd5b to
114d5ab
Compare
Signed-off-by: Andrei Kvapil <[email protected]>
114d5ab to
e265e8b
Compare
Marian Koreniuk (themoriarti)
left a comment
Marian Koreniuk (themoriarti)
left a comment
There was a problem hiding this comment.
Such an approach to deliver everything with cozystack packages is not very good, considering the large number of files that do not carry the direct functionality of the product, we still give customers the opportunity to download helm charts, images, etc. Why can't customers download images and other auxiliary files from another repository? There are specialized CDNs for such purposes. Therefore, it is possible to separate repositories of utilities, tools, image graphics, auxiliary files, articles, etc.
|
These logos are part of Helm charts delivered by cozystack container. Filally we want to make cozystack fully undepended from external sources, including docker images in the future. |
|
Andrei Kvapil (@kvaps) But images is a part of dashboard, maybe we need store this logos in dashboard chart? |
|
I thought about this, but it might be difficult to recompile dashboard image every time we need to add new logo and new Helm charts. From the other side logos now stored in the same HTTP server with our Helm charts. Dashboard is useless in case it can't reach our HTTP server with Helm charts. So for dashbiard we need booth type of assets any way. We have this HTTP server for all assets like helm-charts, grafana dashboards and now also logos. |
Marian Koreniuk (themoriarti)
left a comment
Marian Koreniuk (themoriarti)
left a comment
There was a problem hiding this comment.
If this incident of adding files that are not related to the functionality does not entail the addition of other files to the helm chart, then no, now I understand the approach. But I still recommended to physically store them in another repository and thus we can also download them for the HTTP server.
2 participants
Add all application logos into the cozystack container. Please merge it after #217