Repository navigation
snapshot-controller - #237
Merged
Andrei Kvapil (kvaps) merged 4 commits intoJul 26, 2024
Merged
Conversation
Andrei Kvapil (kvaps)
requested changes
Jul 26, 2024
| privileged: true | ||
| dependsOn: [piraeus-operator,cilium,kubeovn,cert-manager] | ||
|
|
||
| - name: snapshot-controller |
There was a problem hiding this comment.
Let's also added it to distro-full bundle
Contributor
Author
There was a problem hiding this comment.
Remove from paas-full and add only to distro-full?
Contributor
Author
There was a problem hiding this comment.
Didnt noticed also ))
Member
There was a problem hiding this comment.
No, we need it in both distro-full and paas-full bundles as they ship storage
Co-authored-by: Andrei Kvapil <[email protected]>
Andrei Kvapil (kvaps)
approved these changes
Jul 26, 2024
Andrei Kvapil (kvaps)
left a comment
Andrei Kvapil (kvaps)
left a comment
Member
There was a problem hiding this comment.
LGTM, many thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added snapshot-controller to system packages.
It is included in pass-full bundle.
Also added new cluster issuer
selfsigned-cluster-issuer.