Repository navigation
The declarative way to flush redis for our dashboard - #24
Merged
Merged
Conversation
Andrei Kvapil (kvaps)
force-pushed
the
fix-redis
branch
from
February 19, 2024 15:00
2215e9b to
042cc98
Compare
Andrei Kvapil (kvaps)
changed the title
Andrei Kvapil (kvaps)
changed the title
Andrei Kvapil (kvaps)
changed the title
Andrei Kvapil (kvaps)
requested review from
Eduard Generalov (egeneralov) and
George Gaál (gecube)
February 19, 2024 15:11
Serhii Ivanov (s3rj1k)
self-requested a review
February 19, 2024 15:45
Serhii Ivanov (s3rj1k)
approved these changes
Feb 19, 2024
Serhii Ivanov (s3rj1k)
left a comment
Serhii Ivanov (s3rj1k)
left a comment
There was a problem hiding this comment.
LGTM, much better than bash solution
Eduard Generalov (egeneralov)
approved these changes
Feb 19, 2024
George Gaál (gecube)
approved these changes
Feb 19, 2024
George Gaál (gecube)
left a comment
George Gaál (gecube)
left a comment
Collaborator
There was a problem hiding this comment.
anyway we need to post a bug issue to kubeapps project.
Member
Author
Sure, I just sent it to upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves imperative logic of flushing redis from installer.sh to be declarative in platform chart.
Thus now redis will be restarted every time when the flux saves a new artifact for helmrelease in cozy-public namespace:
This logic is not critical, and used only to show actual infromation about the charts in our dashboard.
This is temporary solution but still a better than already existing now. Hopefully we'll refactor it in a while.
fixes #19