Repository navigation
[Backport release-1.4] fix(platform): add OpenSearch to PaaS bundle - #2757
Conversation
# Description Backport of #2648 to `release-1.4`. Assisted-By: Claude <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request ensures that OpenSearch is correctly deployed when the PaaS bundle is enabled. By including the necessary package references in the bundle template, it resolves an issue where the operator and application definitions were present in the repository but not being utilized in the platform configuration. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
github-actions
Bot
added
area/platform
dosubot
Bot
added
the
kind/backport-previous
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the cozystack.opensearch-operator and cozystack.opensearch-application packages to the PaaS bundle template. The reviewer noted that modifying packages/core/platform/ is sensitive and may require updates to the migration flow or an explicit note regarding backward compatibility, as per the repository guidelines.
| {{include "cozystack.platform.package.default" (list "cozystack.rabbitmq-operator" $) }} | ||
| {{include "cozystack.platform.package.default" (list "cozystack.redis-operator" $) }} | ||
| {{include "cozystack.platform.package.default" (list "cozystack.mongodb-operator" $) }} | ||
| {{include "cozystack.platform.package.default" (list "cozystack.opensearch-operator" $) }} |
There was a problem hiding this comment.
This change modifies packages/core/platform/, which is a sensitive component. According to the repository guidelines, changes here can require updates to the migration flow (such as the Helm hook in packages/core/platform/templates/migration-hook.yaml and the runner image with scripts in packages/core/platform/images/migrations/). Since this PR lacks a corresponding migration update or an explicit note that backward compatibility is preserved, please provide an explicit note or update the migration flow.
References
- Changes to packages/core/platform/ can require updates to the migration flow. Flag any change to this package that lacks a corresponding migration update or an explicit note that backward compatibility is preserved. (link)
1 participant
What this PR does
Backport of #2648 to
release-1.4.OpenSearch ships as a complete package set in
release-1.4(
packages/apps/opensearch/,packages/system/opensearch-operator/,packages/system/opensearch-rd/, and theopensearch-operator/opensearch-applicationPackageSources), but the PaaS bundle templatenever referenced the two
cozystack.opensearch-*PackageSources.Result on any cluster with
bundles.paas.enabled=true:opensearch-operatoris not deployed → noOpenSearchClusterCRDopensearch-rdis not deployed → noApplicationDefinition/opensearch,so the dashboard catalog has no OpenSearch entry and tenants cannot
create
opensearches.apps.cozystack.ioThis adds the two missing includes to
packages/core/platform/templates/bundles/paas.yaml, matching #2648 exactly.Release note