Repository navigation
[Backport release-1.4] fix(kubernetes): add spec.timeout to tenant CSI HelmRelease - #2929
Merged
Merged
Conversation
Aligns kubevirt-csi-node HR with every other tenant addon HR in packages/apps/kubernetes/templates/helmreleases/ (cilium, coredns, ingress-nginx, etc.) — all set timeout: 10m, csi.yaml was the only exception. 9f9d8f8 ("Allign timeouts for HelmReleases") missed it. Symptom: e2e NFS test (hack/e2e-apps/run-kubernetes.sh) times out waiting for nfs-test-pod to reach Succeeded. Cozyreport events show the tenant csi HR running Install -> Uninstall -> Install remediation cycles. With install.remediation.retries: -1 and the default 5m Helm timeout, kstatus marks the kubevirt-csi-node DaemonSet 'InProgress' past 5m on a slow tenant control-plane bringup (Kamaji APIs flapping, VM image pulls), helm-controller times out, the remediation uninstalls the DaemonSet, then reinstalls. Any volume mount in flight at that moment is wedged. Observed on PR #2619 CI run 26142986969: csi HR remediation at ~07:07 happened ~10 min into the nfs-test-pod wait, killing the mount and timing out the pod-Succeeded condition. 10m matches the surrounding HRs and gives the DaemonSet headroom without changing remediation semantics on truly-broken installs. Signed-off-by: Myasnikov Daniil <[email protected]> (cherry picked from commit 866588f) (cherry picked from commit d8ba954)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2727 to
release-1.4.