Repository navigation
build(dashboard): pin console image builder to pnpm 11.1.2 and repoint vendor doc link - #3099
Conversation
…t vendor doc link The console Containerfile ran `corepack prepare pnpm@latest`, so the image build could drift to a newer pnpm major than the `[email protected]` pinned in package.json and used by CI. `--frozen-lockfile` guards the lockfile, but pinning the builder makes the image build reproducible and consistent with CI. Also repoints docs/storage-immutability.md off the now-vendored cozystack-ui#6 link to the in-tree console path (follow-up from #2963). Assisted-By: Claude <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
github-actions
Bot
added
size/XS
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs minor maintenance tasks to improve build consistency and documentation accuracy. By pinning the pnpm version in the container build process, it prevents potential drift between build environments and the project's lockfile. Additionally, it cleans up a stale reference in the documentation to reflect the current project structure. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
dosubot
Bot
added
area/build
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates one documentation reference for the Cozystack UI and pins the console image build stage to ChangesBuild tooling
Documentation reference
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in docs/storage-immutability.md to reference the correct path for the Cozystack UI console and pins the pnpm version in the dashboard console's Containerfile to 11.1.2. Feedback suggests leveraging Corepack's native integration with package.json by using RUN corepack enable instead of hardcoding the pnpm version, which ensures the version stays automatically in sync.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # Pin to the version in package.json's packageManager field so the image build | ||
| # matches CI and the lockfile, rather than drifting to a newer pnpm major. | ||
| RUN corepack enable && corepack prepare [email protected] --activate |
There was a problem hiding this comment.
Instead of hardcoding the pnpm version here, you can leverage Corepack's native integration with package.json. When corepack enable is run, any subsequent execution of pnpm (such as pnpm install) will automatically read the packageManager field from package.json, download that exact version, and use it. This avoids having to manually keep the version in sync in multiple files.
RUN corepack enable
Aleksei Sviridkin (lexfrei)
left a comment
Aleksei Sviridkin (lexfrei)
left a comment
There was a problem hiding this comment.
LGTM.
Pinning the console image builder to [email protected] is correct and matches the packageManager field in package.json, so the image build, CI, and the lockfile all resolve to the same pnpm instead of drifting to a newer major from pnpm@latest. The pin lives in a base-only layer ahead of the manifest copy, keeping the download cache-friendly.
The doc repoint in storage-immutability.md correctly swaps the stale cozystack-ui#6 cross-repo reference for the UI's in-tree path now that it lives in the monorepo.
On the suggestion to drop the explicit pin and let corepack read packageManager via bare corepack enable: I would keep the explicit corepack prepare — it runs before package.json is copied, so it pre-fetches pnpm in a layer that survives source changes; deferring to install time would re-download on every manifest change. The current approach is the more deterministic one.
2 participants
What this PR does
Two post-vendor cleanups from the #2963 review:
Containerfilerancorepack prepare pnpm@latest, so the container build could drift to a newer pnpm major than the[email protected]pinned inpackage.jsonand used by CI.--frozen-lockfileguards the lockfile, but pinning the builder makes the image build reproducible and consistent with CI.docs/storage-immutability.mdreferenced the now-vendoredcozystack/cozystack-ui#6; it now points at the in-tree console path.Verification
pnpm typecheck+pnpm testunaffected.package.json'spackageManagerfield.Summary by CodeRabbit
Documentation
Chores