Repository navigation
ci: install flux in the release-1.5 cache warmer - #3480
Merged
Merged
Conversation
`make build` finishes at packages/core/installer, whose image-packages target shells out to `flux push artifact`. The warmer used to target the self-hosted runner, which had flux baked in; #3469 moved it to the ephemeral shape without carrying over the toolchain step that main's warmer and pull-requests.yaml both have for exactly this reason. Confirmed on the first run after #3469 merged (run 30430753152): it failed at 49 minutes with `/bin/sh: 1: flux: not found` on Makefile:35, the last of 28 packages. Everything before it had already exported its cache -- 87 export operations, 70 cache manifests, 34 repos created under CACHE_REGISTRY, including all six ubuntu-container-disk refs -- so the cache came out warm and only the cozystack-packages artifact push was lost. A red warmer is still a broken signal, and nothing else would have reported it. Assisted-By: Claude <[email protected]> Signed-off-by: Myasnikov Daniil <[email protected]>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
size/S
dosubot
Bot
added
area/build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds the flux CLI to the release-1.5 cache warmer, which #3469 moved onto the ephemeral runner shape without carrying over the toolchain step that main's warmer and this branch's
pull-requests.yamlboth have.make buildfinishes atpackages/core/installer, whoseimage-packagestarget shells out toflux push artifact. The self-hosted runner the warmer used to target had flux baked in; the ephemeral shape does not.Confirmed on the first warmer run after #3469 merged (run 30430753152): it failed at 49 minutes with
/bin/sh: 1: flux: not foundonMakefile:35, the last of 28 packages.The cache itself came out warm, because every package exports its cache as it builds and installer is last:
CACHE_REGISTRYubuntu-container-diskrefs (v1.30–v1.35,mode=max)So the only loss was the
cozystack-packages:release-1.5artifact push, and nothing downstream depends on it — PR builds build the installer themselves with flux present. This also settles the open question from #3469: the registry credentials can create repositories under the newcozystack-cache-release-1.5/*namespace, so no fallback to a cache-tag suffix is needed.Fixing it still matters. A permanently red warmer means a genuine breakage is indistinguishable from this known-broken tail, and nothing else reports on that workflow.
The alternative would be teaching the warmer to run the 28 image builds without the artifact push, but no such target exists and it would diverge from main's warmer for no gain. Installing the CLI keeps the two warmers identical in shape, and matches main publishing
cozystack-packages:mainfrom its own warmer.Release note