fix(cozy-lib): make the cozyconfig helpers survive uninjected values - #3647

What this PR does

_cluster and _namespace reach a chart through valuesFrom on the cozystack-values Secret, so they are absent whenever a chart is rendered on its own: helm lint, a plain helm template, and any helm-unittest suite that does not set them. Twelve of the helpers in _cozyconfig.tpl read straight through the missing map and abort the render instead of returning the empty default they document.

Two spellings, one cause. index .Values._cluster "root-host" raises index of untyped nil; .Values._namespace.host raises nil pointer evaluating interface {}.host. In both, the trailing | default "" never runs, because it applies to the result and there is no result, only an error. That default covered a key missing from a map that exists, never a missing map.

The guard goes on the map, which is what cozy-lib.images-registry in this same file already did:

(index (.Values._cluster | default dict) "root-host") | default ""

index on an empty map returns nil harmlessly, so the trailing default applies as it always read, and with the map present | default dict returns it untouched.

This fixes no chart that is failing today. The charts that cannot render standalone read the injected values directly in their own templates rather than through these helpers, so a change to the library does not reach them; they are handled where they live. Worth being blunt about the same point from the other side: twelve of the thirteen helpers here currently have no callers anywhere in packages/. Only cozy-lib.images-registry is reached, from cozy-lib.image, and it was already guarded. The guard is still worth having on the rest, because they are the library's public surface, they are what a chart author copies when reaching for cluster configuration, and a broken spelling propagates by being read. cozy-lib.image is called from four templates, so these helpers do get adopted once they exist.

Rendered output does not change, and that is measured rather than argued. All 34 charts that symlink cozy-lib were rendered before and after, both with the injected values populated and with them set to empty maps, and every result is byte-identical. That check needs a control: the first comparison showed eight charts differing, which looks like a regression in a library change. Rendering the unchanged tree twice reproduces exactly those eight, because they generate passwords. Subtracting the control leaves zero real differences.

The suite lives in cozy-lib-tests, which is where library behaviour is pinned, since a library chart renders nothing of its own. One case covers the uninjected state, which needs no mocking because neither key appears in any values file, and one covers the injected state so the guard cannot quietly change what a populated map returns. The injected case pins scheduling and branding as whole YAML documents rather than by substring: those two had their bodies restructured rather than wrapped, and a substring assertion survives the loss of the toYaml that produces the document, because the key name also appears in Go's default map formatting. Against the unguarded helpers the first case fails with index of untyped nil.

Three things left deliberately undone, so they are not mistaken for oversights. The header comments in _cozyconfig.tpl say where these values come from but not what the helpers now do when they are absent, which is the contract this change creates and would be better stated next to the helpers than only in the suite. Chart.yaml in cozy-lib-tests still carries name: quota from when that chart covered one helper family, so the runner prints ### Chart [ quota ] for a suite that now covers three. And the mixed state, one map injected and the other not, has no case of its own; the two guards are independent so composition covers it, and a third case would pin nothing new.

Relates to #3646.

Screenshots

Downstream repositories

• No downstream repository is affected by this change
• cozystack/website - follow-up:
• cozystack/terraform-provider-cozystack - follow-up:
• cozystack/ansible-cozystack - follow-up:
• cozystack/ccp - follow-up:
• cozystack/talm - follow-up:
• cozystack/cozyhr - follow-up:
• cozystack/cozy-proxy - follow-up:
• cozystack/cozystack-telemetry-server - follow-up:
• cozystack/external-apps-example - follow-up:
• cozystack/examples - follow-up:

Release note

fix(cozy-lib): the cozyconfig helpers now return their documented empty defaults when the platform has not injected `_cluster` / `_namespace`, instead of aborting the render, so a chart using them can be rendered and unit-tested on its own

Summary by CodeRabbit

• Bug Fixes

  • Improved configuration handling when cluster or namespace settings are missing, preventing template rendering errors.
  • Preserved existing configuration values for scheduling, branding, networking, registries, and component namespaces.

• Tests

  • Added coverage for configurations with missing platform values.
  • Added validation that injected cluster and namespace settings render correctly.