Skip to content

[Backport release-1.5] fix(velero): apply CRD updates on upgrade via CreateReplace - #3881

Closed
github-actions[bot] wants to merge 1 commit into
release-1.5from
backport-3727-to-release-1.5
Closed

github-actions[bot] wants to merge 1 commit into
release-1.5from
backport-3727-to-release-1.5

Conversation

@github-actions

Copy link
Copy Markdown

Description

Backport of #3727 to release-1.5.

@github-actions

Copy link
Copy Markdown
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-3727-to-release-1.5
git worktree add --checkout .worktree/backport-3727-to-release-1.5 backport-3727-to-release-1.5
cd .worktree/backport-3727-to-release-1.5
git reset --hard HEAD^
git cherry-pick -x f4d812cfb919496dfdfbca2ca8a3047a702d96cb
git push --force-with-lease

@myasnikovdaniil

Copy link
Copy Markdown
Contributor

Closing, the bug is not reachable on this branch.

velero has been pinned at chart 11.0.0 / appVersion 1.17.0 continuously across v1.4.0, v1.4.4, v1.5.0, v1.5.3 and release-1.5 head. The status.phase: Unsupported value: "Queued" failure needs velero 1.18.1, which is only on main and release-1.6, and there is no velero version change anywhere in the 1.4 to 1.5 range. So no 1.5.x cluster can hit it.

Meanwhile upgradeCRDs: CreateReplace would replace velero CRDs on every future 1.5.x upgrade on a branch where those CRDs have never needed to change. Preventive hardening with no defect behind it, and it is not free.

It stays correct and wanted on the 1.6 line, #3728 covers it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants