docs(kubevirt): name every payload line the tail checks do not cover - #4340

europrinter (@yankawai) NOT LGTM. Every claim in the new comment holds, but the list still misses one uncovered payload line, so the comment is not complete yet.

Business context: the comment #4254 left in the kubevirt make update recipe reads as if only the device and CPU payloads escape the tail checks, and this PR is meant to name every payload line that does.

The missing one is the entry that renders each disabled gate a user adds. It has the same shape as the extraFeatureGates entry: a - {{ . }} line inside a range, and no check looks at it. Makefile line 84 greps only the {{- range .Values.disabledFeatureGates }} directive. Lines 85-88 grep the key and the three static entries. On a copy of templates/kubevirt-cr.yaml I deleted that line (line 97), and make update CR_FILE=<copy> exits 0. Rendering the copy with disabledFeatureGates={DeclarativeHotplugVolumes} gives a list without that gate, so a configured value silently stops taking effect. As a control, dropping - Template from a clean copy fails the target as expected.

The rest checks out. The device tables, the cpuAllocationRatio value and the extraFeatureGates entry are all outside the checks, and I got the same exit 0 on the extraFeatureGates case. The awk at lines 98-102 is the only check that validates a block whole.

Two ways to fix it: add the disabledFeatureGates entry to the list, or drop the list. "Every other payload line stays outside these checks" is true without it, and the list is the part that goes stale. The PR body becomes the merge commit message as is, so "names all three uncovered payloads" there needs the same fix.

I'm not asking for the code change you deferred.

europrinter (@yankawai) LGTM. The list is complete now: every payload line the inserts add is either checked by the tail or named in the comment.

I built the set from the inserts myself. The tail greps each insert's directive, the disabledFeatureGates: key and the three static entries, and the awk checks the migrations block whole. That leaves the device tables, the cpuAllocationRatio line and the two - {{ . }} entries, which is what the comment lists. On copies of the CR, deleting either - {{ . }} entry, the cpuAllocationRatio line or the permittedHostDevices toYaml line leaves make update CR_FILE=<copy> at exit 0. Dropping - Template still fails the target.

The other sentences hold, and the body no longer says three.