Repository navigation
[Backport release-1.6] fix(registry): preserve write options in aggregated storage - #4370
Merged
Merged
Conversation
Author
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-3937-to-release-1.6
git worktree add --checkout .worktree/backport-3937-to-release-1.6 backport-3937-to-release-1.6
cd .worktree/backport-3937-to-release-1.6
git reset --hard HEAD^
git cherry-pick -x a9812477e2d89fab070eb9e1fe177785cc9391e1 a20c7069401b3be4d016324978c32c58a796e1ac 39da2300d20ad278c5f850fa1d49fd416885e0c2 29351bd7fa018b965d749ad27eac88e4819b8884 1b576bc63868aa766a920a10e9966ba04abbd6f1
git push --force-with-lease |
1 of 11 tasks
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: cozystack/cozystack/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Yan Bondarenko <[email protected]> Assisted-by: LLM (cherry picked from commit a981247) Signed-off-by: Myasnikov Daniil <[email protected]>
Dry-run must expose the same deletion state as a real request without persisting it. Shared option objects can hide dropped fields in tests, and an unreachable patch method offers no API coverage. Signed-off-by: Yan Bondarenko <[email protected]> Assisted-by: LLM (cherry picked from commit a20c706) Signed-off-by: Myasnikov Daniil <[email protected]>
Aggregated endpoints must retain backend HTTP codes and reasons so clients can distinguish conflicts and admission failures. Dry-run deletion also depends on current finalizers, which a cached read can miss. Signed-off-by: Yan Bondarenko <[email protected]> Assisted-by: LLM (cherry picked from commit 39da230) Signed-off-by: Myasnikov Daniil <[email protected]>
Backing resource names are not part of the aggregated API contract. Clients need the requested resource identity and the original status code and reason to handle rejected writes consistently. Signed-off-by: Yan Bondarenko <[email protected]> Assisted-by: LLM (cherry picked from commit 29351bd) Signed-off-by: Myasnikov Daniil <[email protected]>
WrapPreservingStatus rewrites Group, Kind and Name of a backend status to the aggregated resource but left Details.UID as the HelmRelease's, so a client that keys on details saw an identity the tenant cannot look up. The UID goes with the rest of the remap, and a test pins it. Signed-off-by: Yan Bondarenko <[email protected]> Assisted-by: LLM (cherry picked from commit 1b576bc) Signed-off-by: Myasnikov Daniil <[email protected]>
myasnikovdaniil
force-pushed
the
backport-3937-to-release-1.6
branch
from
September 23, 2026 10:26
c55bfbf to
08a5cf9
Compare
github-actions
Bot
added
size/XXL
myasnikovdaniil
marked this pull request as ready for review
September 23, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #3937 to
release-1.6.